-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix panic when printing log when lastSuccessfulTime of cronjob is nil #3683
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3683 +/- ##
==========================================
- Coverage 56.63% 56.61% -0.02%
==========================================
Files 221 221
Lines 20831 20831
==========================================
- Hits 11797 11793 -4
- Misses 8411 8414 +3
- Partials 623 624 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks~
How do you find it?
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you help cherry-pick it to the affected release branch? |
Through the logging system. |
…pstream-release-1.6 Automated cherry pick of #3683: fix aggregateCronJobStatus panic
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix aggregateCronJobStatus panic
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
When job is not successful even once,
lastSuccessfulTime
will always benil
. Printing logs at this time will cause a panic.Does this PR introduce a user-facing change?: