Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize download percentage log #3715

Merged

Conversation

learner0810
Copy link
Member

@learner0810 learner0810 commented Jun 27, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Optimize download percentage log

before
wecom-temp-e9817f106be17db525c4d97c3f0f15a4

now
wecom-temp-66fbc84b773ae010abed4e9710163797

NONE

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 27, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2023
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
@calvin0327
Copy link

calvin0327 commented Jun 27, 2023

@learner0810 Good find.

please fill in user-facing change

@learner0810
Copy link
Member Author

please fill in user-facing change

done. PTAL

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @learner0810 for doing this.
Long time no see, welcome back!

LGTM.

@calvin0327
Copy link

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@learner0810
Copy link
Member Author

Thanks @learner0810 for doing this. Long time no see, welcome back!

LGTM.

Thank you very much, I will spend more time in the Kalmada community in the future.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@karmada-bot karmada-bot merged commit 912ba8e into karmada-io:master Jun 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants