Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: karmadactl adds a karmada-metrics-adapter addons. #3717

Merged
merged 1 commit into from
Jun 28, 2023
Merged

feat: karmadactl adds a karmada-metrics-adapter addons. #3717

merged 1 commit into from
Jun 28, 2023
+389 −10

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Jun 27, 2023 •
edited by RainbowMango
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #3626

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Added `karmada-metrics-adapter` to addons.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #3717 (40e4d8d) into master (b005d5b) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3717      +/-   ##
==========================================
- Coverage   55.68%   55.68%   -0.01%     
==========================================
  Files         222      222              
  Lines       21195    21195              
==========================================
- Hits        11803    11802       -1     
- Misses       8765     8766       +1     
  Partials      627      627
Flag Coverage Δ
unittests 55.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

RainbowMango
RainbowMango reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @jwcesign

@chaunceyjiang
Copy link
Member Author

image

@chaunceyjiang
Copy link
Member Author

/cc @wuyingjun-lucky @jwcesign PTAL.

@wuyingjun-lucky
Copy link
Member

/assign
I will review it this week

jwcesign
jwcesign reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other lgtm

pkg/karmadactl/addons/enable.go Outdated Show resolved Hide resolved
@chaunceyjiang chaunceyjiang force-pushed the karmada-metrics-adapter-ctl branch 2 times, most recently from 3cf8de8 to 40e4d8d Compare June 28, 2023 02:10
@chaunceyjiang
feat: karmadactl adds the karmada-metrics-adapter addons.
fc975e8 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@wuyingjun-lucky
Copy link
Member

/approve
leave lgtm to @jwcesign

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@jwcesign
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@karmada-bot karmada-bot merged commit c39856b into karmada-io:master Jun 28, 2023
11 checks passed
@chaunceyjiang chaunceyjiang deleted the karmada-metrics-adapter-ctl branch June 28, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@wuyingjun-lucky wuyingjun-lucky wuyingjun-lucky left review comments

@jwcesign jwcesign jwcesign left review comments

@carlory carlory Awaiting requested review from carlory

Assignees

@wuyingjun-lucky wuyingjun-lucky

@jwcesign jwcesign

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chaunceyjiang @codecov-commenter @wuyingjun-lucky @karmada-bot @jwcesign @RainbowMango