Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spilt karmada-config ConfigMap in helm chart and split crd yaml into group files #3721

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In order to fix the issue: #3713

Which issue(s) this PR fixes:
Fixes #3713

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: changzhen <changzhen5@huawei.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 27, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2023
@XiShanYongYe-Chang
Copy link
Member Author

/cc @Poor12 @RainbowMango

@codecov-commenter
Copy link

Codecov Report

Merging #3721 (fad05ce) into master (b005d5b) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3721   +/-   ##
=======================================
  Coverage   55.68%   55.69%           
=======================================
  Files         222      222           
  Lines       21195    21195           
=======================================
+ Hits        11803    11805    +2     
+ Misses       8765     8763    -2     
  Partials      627      627           
Flag Coverage Δ
unittests 55.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Poor12
Copy link
Member

Poor12 commented Jun 28, 2023

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@karmada-bot karmada-bot merged commit 7afb66d into karmada-io:master Jun 28, 2023
12 checks passed
@RainbowMango
Copy link
Member

I just realized that karmadactl init is using the crd files, please help to confirm it still works with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new API faied for chart-lint-test CI
5 participants