-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karmada Operator: Add Leader Elect to Manifests #3733
Karmada Operator: Add Leader Elect to Manifests #3733
Conversation
Welcome @RuliXu! It looks like this is your first PR to karmada-io/karmada 🎉 |
5dd5633
to
e0d1afa
Compare
/assign @calvin0327 |
Signed-off-by: RuliXu <lily.xu@daocloud.io>
e0d1afa
to
c79ed77
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RuliXu for doing this.
@calvin0327 Do we have any E2E tests covering the operator functionality?
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3733 +/- ##
==========================================
- Coverage 55.69% 55.68% -0.01%
==========================================
Files 222 222
Lines 21195 21195
==========================================
- Hits 11804 11803 -1
- Misses 8764 8765 +1
Partials 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. |
Yes, we don't have any e2e yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Double agree, should we open an issue to track this? |
Ok, that's sure. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Karmada components have the ability of leader elect, but not yet used in manifests of karmada operator.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: