Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karmada Operator: Add Leader Elect to Manifests #3733

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

RuliXu
Copy link
Contributor

@RuliXu RuliXu commented Jun 29, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Karmada components have the ability of leader elect, but not yet used in manifests of karmada operator.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot
Copy link
Collaborator

Welcome @RuliXu! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 29, 2023
@RuliXu RuliXu force-pushed the add-manifests-leader-elect branch from 5dd5633 to e0d1afa Compare June 29, 2023 05:49
@RuliXu
Copy link
Contributor Author

RuliXu commented Jun 29, 2023

/assign @calvin0327

Signed-off-by: RuliXu <lily.xu@daocloud.io>
@RuliXu RuliXu force-pushed the add-manifests-leader-elect branch from e0d1afa to c79ed77 Compare June 29, 2023 07:01
@RuliXu RuliXu changed the title Add Leader Elect to Manifests Karmada Operator: Add Leader Elect to Manifests Jun 29, 2023
@calvin0327
Copy link

/assign

@calvin0327
Copy link

calvin0327 commented Jun 29, 2023

@RuliXu Thanks for your first pr, It looks good.
/lgtm

@Poor12 @lonelyCZ /cc

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RuliXu for doing this.

@calvin0327 Do we have any E2E tests covering the operator functionality?

@codecov-commenter
Copy link

Codecov Report

Merging #3733 (c79ed77) into master (626564d) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3733      +/-   ##
==========================================
- Coverage   55.69%   55.68%   -0.01%     
==========================================
  Files         222      222              
  Lines       21195    21195              
==========================================
- Hits        11804    11803       -1     
- Misses       8764     8765       +1     
  Partials      627      627              
Flag Coverage Δ
unittests 55.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@calvin0327
Copy link

Thanks @RuliXu for doing this.

@calvin0327 Do we have any E2E tests covering the operator functionality?

Yes, we don't have any e2e yet.
At this stage, I think we need to add e2e to cover the whole install, update, and uninstall process.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@RainbowMango
Copy link
Member

At this stage, I think we need to add e2e to cover the whole install, update, and uninstall process.

Double agree, should we open an issue to track this?

@karmada-bot karmada-bot merged commit b01cf50 into karmada-io:master Jun 30, 2023
11 checks passed
@calvin0327
Copy link

At this stage, I think we need to add e2e to cover the whole install, update, and uninstall process.

Double agree, should we open an issue to track this?

Ok, that's sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants