-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align federated daemonsets.apps.kruise.io observedGeneration semantics with its native #5167
Align federated daemonsets.apps.kruise.io observedGeneration semantics with its native #5167
Conversation
…s with its native Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5167 +/- ##
=======================================
Coverage 28.22% 28.22%
=======================================
Files 632 632
Lines 43548 43548
=======================================
+ Hits 12290 12293 +3
+ Misses 30360 30359 -1
+ Partials 898 896 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
/lgtm
...ourcecustomizations/apps.kruise.io/v1alpha1/DaemonSet/testdata/observed-daemonset-nginx.yaml
Show resolved
Hide resolved
Thanks for your work! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yike21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #4870
Special notes for your reviewer:
Does this PR introduce a user-facing change?: