-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominates Amir and Chaosi as the owners of helm chart #5505
Nominates Amir and Chaosi as the owners of helm chart #5505
Conversation
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
thank you very much |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5505 +/- ##
=======================================
Coverage 31.70% 31.70%
=======================================
Files 643 643
Lines 44445 44445
=======================================
Hits 14092 14092
Misses 29324 29324
Partials 1029 1029
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❤️ |
+1 💯 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR nominates @a7i and @chaosi-zju as the owners of the helm chart.
Both @a7i and @chaosi-zju have been contributing significantly to the helm chart for a long time.
Their expertise are evident in every PR they sent and reviewed. Given their deep knowledge of the codebase and his commitment to the quality, I believe they are the perfect fit for this role.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: