Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg+test: unify the usage of policyv1alpha1 operators #5508

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 9, 2024

Description

In this commit, we unify the usage of policyv1alpha1 operators, specifically OverriderOpAdd, OverriderOpRemove, and OverriderOpReplace.

What type of PR is this?

/kind cleanup

Additional Context

While testing the override policy (#5495), I identified an opportunity to improve consistency by unifying the operators, leading to this submission.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 9, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 9, 2024
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.34%. Comparing base (32c2ef7) to head (be87fd5).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5508      +/-   ##
==========================================
+ Coverage   31.70%   32.34%   +0.63%     
==========================================
  Files         643      643              
  Lines       44445    44445              
==========================================
+ Hits        14090    14374     +284     
+ Misses      29325    28981     -344     
- Partials     1030     1090      +60     
Flag Coverage Δ
unittests 32.34% <ø> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

/retest
Unrelated test:

ERROR: failed to solve: alpine:3.20.3: failed to resolve source metadata for docker.io/library/alpine:3.20.3: failed to do request: Head "https://registry-1.docker.io/v2/library/alpine/manifests/3.20.3": EOF

@mohamedawnallah
Copy link
Contributor Author

@RainbowMango all test cases passed now :)

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@karmada-bot karmada-bot merged commit 4ac95b9 into karmada-io:master Sep 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants