-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg+test: unify the usage of policyv1alpha1 operators #5508
pkg+test: unify the usage of policyv1alpha1 operators #5508
Conversation
c7af624
to
0b1de48
Compare
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
0b1de48
to
be87fd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5508 +/- ##
==========================================
+ Coverage 31.70% 32.34% +0.63%
==========================================
Files 643 643
Lines 44445 44445
==========================================
+ Hits 14090 14374 +284
+ Misses 29325 28981 -344
- Partials 1030 1090 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest
|
@RainbowMango all test cases passed now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unify the usage of
policyv1alpha1
operators, specificallyOverriderOpAdd
,OverriderOpRemove
, andOverriderOpReplace
.What type of PR is this?
/kind cleanup
Additional Context
While testing the override policy (#5495), I identified an opportunity to improve consistency by unifying the operators, leading to this submission.
Does this PR introduce a user-facing change?: