Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to Specify Extra Volumes and Volume Mounts for Karmada API Server Component #5509

Merged

Conversation

jabellard
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Today, when creating a Karmada instance to be managed by the Karmada operator, it's possible to specify extra args for the control plane components. However, it's not possible to specify extra volumes and volume mounts. This feature request is for providing the ability to specify extra volumes and volume mounts for the Karmada components.

Why is this needed:
At Bloomberg, we're currently building a managed Karmada platform and want to use the Karmada operator to manage the entire lifecycle of managed Karmada instances. We have tenants who have requirements such as the following:

  • Ability to configure custom AuthN webhook
  • Ability to configure encryption at rest

Given that it's already possible to specify extra args for components like the API server, having the ability to also specify extra volumes and volume mounts will enable those use cases.

Which issue(s) this PR fixes:
Fixes #5272

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

When creating a Karmada instance to be managed by the Karmada operator, it's now possible to optionally specify extra volumes and volume mounts via the `extraVolumes` and `extraVolumemounts` flags, respectively, for the Karmada API server component.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 9, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.86%. Comparing base (54b90a2) to head (c45b817).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/util/patcher/pather.go 0.00% 8 Missing ⚠️
operator/pkg/controlplane/apiserver/apiserver.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5509      +/-   ##
==========================================
+ Coverage   32.32%   33.86%   +1.53%     
==========================================
  Files         643      643              
  Lines       44445    44509      +64     
==========================================
+ Hits        14368    15071     +703     
+ Misses      28985    28288     -697     
- Partials     1092     1150      +58     
Flag Coverage Δ
unittests 33.86% <0.00%> (+1.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, just give another look at the field names that I mentioned on #5276 (comment).

Signed-off-by: Joe Nathan Abellard <contact@jabellard.com>

Initial structure

Signed-off-by: Joe Nathan Abellard <contact@jabellard.com>

Update api

Signed-off-by: Joe Nathan Abellard <contact@jabellard.com>

Update api

Signed-off-by: Joe Nathan Abellard <contact@jabellard.com>
@jabellard
Copy link
Contributor Author

Generally looks good to me, just give another look at the field names that I mentioned on #5276 (comment).

Just pushed some changes to address.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@karmada-bot karmada-bot merged commit 4dfff39 into karmada-io:master Sep 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add The Ability to Specify Extra Volumes and Volume Mounts for Karmada Components
5 participants