-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/webhook: log mutating handlers in OverridePolicy
, ClusterPropagationPolicy
, and MultiClusterService
#5521
pkg/webhook: log mutating handlers in OverridePolicy
, ClusterPropagationPolicy
, and MultiClusterService
#5521
Conversation
In this commit, we log the mutating handlers for `OverridePolicy`, `ClusterPropagationPolicy`, and `MultiClusterService`. Specifically, it logs information about the mutation of these resources, including the namespace, name, and the operation type from the admission request. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
OverridePolicy
, ClusterPropagationPolicy
, and MultiClusterService
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5521 +/- ##
==========================================
+ Coverage 31.70% 32.45% +0.75%
==========================================
Files 643 643
Lines 44445 44500 +55
==========================================
+ Hits 14090 14443 +353
+ Misses 29325 28963 -362
- Partials 1030 1094 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d0c5593
to
7506097
Compare
Closing and reopening some flaky e2e test failures... |
/ok-to-test |
Thanks! Will try it next time instead of closing and reopening :) |
7506097
to
df270fa
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/kind cleanup
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@liangyuanpeng I've tried
Any thoughts? |
Description
In this commit, we log the mutating handlers for
OverridePolicy
,ClusterPropagationPolicy
, andMultiClusterService
. Specifically, it logs information about the mutation of these resources, including the namespace, name, and the operation type from the admission request.Motivation and Context
During testing of the multi-cluster service webhook (#5517), I observed that all mutating webhook handlers include logging functionality, except for the handlers related to
OverridePolicy
,ClusterPropagationPolicy
, andMultiClusterService
. Adding logging to these handlers will improve debugging and enhance visibility into the operations they handle, which is the purpose of this PR.What type of PR is this?
/kind feature
Does this PR introduce a user-facing change?: