pkg/webhook: refactor Federated Resource Quota test #5544
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/L
mohamedawnallah
force-pushed
the
refactorFederatedResourceQuota
branch
from
108b5f5
to
88a8be5
Compare
In this commit, we refactor `FederatedResourceQuota` webhook mainly matching on substrings instead of whole strings for reliability and resilience and reformat the test case names to follow format `Function_Scenario_ExpectedResult` for better readability. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah
force-pushed
the
refactorFederatedResourceQuota
branch
from
88a8be5
to
fe408f9
Compare
mohamedawnallah
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5544 +/- ##
==========================================
+ Coverage 33.71% 34.14% +0.43%
==========================================
Files 643 643
Lines 44500 44509 +9
==========================================
+ Hits 15001 15196 +195
+ Misses 28357 28157 -200
- Partials 1142 1156 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
Hi @mohamedawnallah, would you like to have a look at #5580. |
Description
In this commit, we refactor
FederatedResourceQuotawebhook mainly matching on substrings instead of whole strings for reliability and resilience and reformat the test case names to follow formatFunction_Scenario_ExpectedResultfor better readability.What type of PR is this?
/kind cleanup
Which issue(s) this PR fixes:
Follow-up of #5287.
Does this PR introduce a user-facing change?: