Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mTLS Configuration for Karmada Scheduler & Descheduler Components #5546

Merged

Conversation

jabellard
Copy link
Contributor

@jabellard jabellard commented Sep 13, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

A recent change introduced new flags for configuring mTLS for the Karmada Scheduler & Descheduler components. As such, the manifest templates for those components were changed accordingly to reflect the new change. Configuration of the new flags now require that a volume be mounted to use as the source of the TLS data. However, it looks like there's one more change required that was missed.

Which issue(s) this PR fixes:
Fixes #5545

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-operator`: Fixed the issue where the manifests for the `karmada-scheduler` and `karmada-descheduler` components were not parsed correctly.

…escheduler Components

Signed-off-by: Joe Nathan Abellard <contact@jabellard.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 13, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2024
@jabellard jabellard changed the title Set Karmada Cert Secret Used For Configuring mTLS for Scheduler & Descheduler Components Fix mTLS Configuration for Karmada Scheduler & Descheduler Components Sep 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (2e60a6e) to head (24d9e12).

Files with missing lines Patch % Lines
operator/pkg/controlplane/controlplane.go 0.00% 22 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5546      +/-   ##
==========================================
- Coverage   34.14%   34.13%   -0.01%     
==========================================
  Files         643      643              
  Lines       44509    44511       +2     
==========================================
- Hits        15197    15196       -1     
- Misses      28156    28159       +3     
  Partials     1156     1156              
Flag Coverage Δ
unittests 34.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member

seems like same PR as #5519

@zhzhuang-zju

@zhzhuang-zju
Copy link
Contributor

seems like same PR as #5519

@zhzhuang-zju

Yeah, We try to fix this issue in #5519; you can track it there @jabellard .

@RainbowMango
Copy link
Member

/lgtm
/approve

We can have both of them.

@jabellard I added a release note on this PR and we will backport this to release-1.11.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2024
@karmada-bot karmada-bot merged commit ba360c9 into karmada-io:master Sep 14, 2024
12 checks passed
karmada-bot added a commit that referenced this pull request Sep 14, 2024
…5546-upstream-release-1.11

Automated cherry pick of #5546: Set Karmada Cert Secret Used For Configurating mTLS for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mTLS Configuration for Karmada Scheduler & Descheduler Components
6 participants