Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --bind-address and --bind-address from karmada-scheduler-estimator #5555

Merged

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Sep 16, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
part of #5547

Special notes for your reviewer:
Based on this comment, I assign different default values to --metrics-bind-address and --health-probe-bind-address. I've chosen to align with other components by using 8080 as the default for --metrics-bind-address.

Does this PR introduce a user-facing change?:

`karmada-scheduler-estimator`: Removed `--bind-address` and `--secure-port` flags which were deprecated in release-1.11 and replaced by `--health-probe-bind-address` and `--metrics-bind-address`.

Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 16, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.15%. Comparing base (4c8bcd4) to head (a72b72b).

Files with missing lines Patch % Lines
cmd/scheduler-estimator/app/options/options.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5555      +/-   ##
==========================================
+ Coverage   34.14%   34.15%   +0.01%     
==========================================
  Files         643      643              
  Lines       44524    44512      -12     
==========================================
+ Hits        15203    15205       +2     
+ Misses      28165    28152      -13     
+ Partials     1156     1155       -1     
Flag Coverage Δ
unittests 34.15% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Sep 19, 2024
@RainbowMango
Copy link
Member

/retitle Remove deprecated --bind-address and --bind-address from karmada-scheduler-estimator
/kind deprecation

@karmada-bot karmada-bot changed the title Remove BindAddress & SecurePort of karmada-scheduler-estimator Remove deprecated --bind-address and --bind-address from karmada-scheduler-estimator Sep 19, 2024
@RainbowMango
Copy link
Member

cc @whitewindmills would you like to take a look?

@whitewindmills
Copy link
Member

thanks
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@karmada-bot karmada-bot merged commit e97f2bb into karmada-io:master Sep 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants