[feature] add AwsCliS3DestinationFactory

kbond · Nov 10, 2022 · 6446a86 · 6446a86
1 parent 22619ca
commit 6446a86
Show file tree

Hide file tree

Showing 14 changed files with 71 additions and 10 deletions.
diff --git a/src/DependencyInjection/Factory/Destination/AwsCliS3DestinationFactory.php b/src/DependencyInjection/Factory/Destination/AwsCliS3DestinationFactory.php
@@ -0,0 +1,49 @@
+<?php
+
+namespace Zenstruck\BackupBundle\DependencyInjection\Factory\Destination;
+
+use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
+use Symfony\Component\DependencyInjection\ChildDefinition;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Reference;
+use Zenstruck\Backup\Destination\AwsCliS3Destination;
+use Zenstruck\BackupBundle\DependencyInjection\Factory\Factory;
+
+/**
+ * @author Kevin Bond <kevinbond@gmail.com>
+ */
+class AwsCliS3DestinationFactory implements Factory
+{
+    public function getName(): string
+    {
+        return 'aws_cli_s3';
+    }
+
+    public function create(ContainerBuilder $container, string $id, array $config): Reference
+    {
+        $serviceId = \sprintf('zenstruck_backup.destination.%s', $id);
+
+        $container->setDefinition($serviceId, new ChildDefinition('zenstruck_backup.destination.abstract_aws_cli_s3'))
+            ->replaceArgument(0, $id)
+            ->replaceArgument(1, $config['bucket'])
+            ->replaceArgument(2, $config['timeout'])
+            ->replaceArgument(3, $config['options'])
+            ->addTag('zenstruck_backup.destination')
+        ;
+
+        return new Reference($serviceId);
+    }
+
+    public function addConfiguration(ArrayNodeDefinition $builder): void
+    {
+        $builder
+            ->children()
+                ->scalarNode('bucket')->isRequired()->example('s3://foobar/backups')->end()
+                ->integerNode('timeout')->defaultValue(AwsCliS3Destination::DEFAULT_TIMEOUT)->end()
+                ->arrayNode('options')
+                    ->prototype('scalar')->end()
+                ->end()
+            ->end()
+        ;
+    }
+}
diff --git a/src/DependencyInjection/Factory/Destination/FlysystemDestinationFactory.php b/src/DependencyInjection/Factory/Destination/FlysystemDestinationFactory.php
@@ -31,7 +31,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Destination/S3CmdDestinationFactory.php b/src/DependencyInjection/Factory/Destination/S3CmdDestinationFactory.php
@@ -34,7 +34,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Destination/StreamDestinationFactory.php b/src/DependencyInjection/Factory/Destination/StreamDestinationFactory.php
@@ -31,7 +31,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Factory.php b/src/DependencyInjection/Factory/Factory.php
@@ -25,5 +25,5 @@ public function create(ContainerBuilder $container, string $id, array $config):
     /**
      * Adds configuration nodes for the factory.
      */
-    public function addConfiguration(ArrayNodeDefinition $builder);
+    public function addConfiguration(ArrayNodeDefinition $builder): void;
 }
diff --git a/src/DependencyInjection/Factory/Namer/SimpleNamerFactory.php b/src/DependencyInjection/Factory/Namer/SimpleNamerFactory.php
@@ -31,7 +31,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Namer/TimestampNamerFactory.php b/src/DependencyInjection/Factory/Namer/TimestampNamerFactory.php
@@ -34,7 +34,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Processor/GzipArchiveProcessorFactory.php b/src/DependencyInjection/Factory/Processor/GzipArchiveProcessorFactory.php
@@ -34,7 +34,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Processor/ZipArchiveProcessorFactory.php b/src/DependencyInjection/Factory/Processor/ZipArchiveProcessorFactory.php
@@ -34,7 +34,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Source/MySqlDumpSourceFactory.php b/src/DependencyInjection/Factory/Source/MySqlDumpSourceFactory.php
@@ -39,7 +39,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/DependencyInjection/Factory/Source/RsyncSourceFactory.php b/src/DependencyInjection/Factory/Source/RsyncSourceFactory.php
@@ -35,7 +35,7 @@ public function create(ContainerBuilder $container, string $id, array $config):
         return new Reference($serviceId);
     }
 
-    public function addConfiguration(ArrayNodeDefinition $builder)
+    public function addConfiguration(ArrayNodeDefinition $builder): void
     {
         $builder
             ->children()

diff --git a/src/Resources/config/destinations.xml b/src/Resources/config/destinations.xml
@@ -19,5 +19,11 @@
             <argument /> <!-- timeout -->
             <argument type="collection" /> <!-- options -->
         </service>
+        <service id="zenstruck_backup.destination.abstract_aws_cli_s3" class="Zenstruck\Backup\Destination\AwsCliS3Destination" abstract="true" public="false">
+            <argument /> <!-- name -->
+            <argument /> <!-- bucket -->
+            <argument /> <!-- timeout -->
+            <argument type="collection" /> <!-- options -->
+        </service>
     </services>
 </container>
diff --git a/src/Resources/config/factories.xml b/src/Resources/config/factories.xml
@@ -39,5 +39,8 @@
         <service id="zenstruck_backup.destination_factory.s3cmd" class="Zenstruck\BackupBundle\DependencyInjection\Factory\Destination\S3CmdDestinationFactory" public="false">
             <tag name="zenstruck_backup.destination_factory" />
         </service>
+        <service id="zenstruck_backup.destination_factory.aws_cli_s3" class="Zenstruck\BackupBundle\DependencyInjection\Factory\Destination\AwsCliS3DestinationFactory" public="false">
+            <tag name="zenstruck_backup.destination_factory" />
+        </service>
     </services>
 </container>
diff --git a/tests/Fixtures/valid_config.yml b/tests/Fixtures/valid_config.yml
@@ -30,6 +30,9 @@ destinations:
     stream:
         stream:
             directory: /foo
+    s3_alt:
+        aws_cli_s3:
+            bucket: "s3://foobar/backups"
 profiles:
     daily:
         scratch_dir: "%kernel.project_dir%/cache/backup"