Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support of php 7.x, drop support symfony < 5.4 #16

Merged
merged 1 commit into from
Nov 10, 2022
Merged

feat: drop support of php 7.x, drop support symfony < 5.4 #16

merged 1 commit into from
Nov 10, 2022

Conversation

Chris53897
Copy link
Contributor

, add support symfony 6, add strong types.

Please check for BC checks of strong types.

I am not sure about these changes. Nullable or not.
https://github.com/kbond/php-backup/compare/master...Chris53897:php-backup:feature/modernize?expand=1#diff-abf1fa77a19f720052b75bc802df0260157b9064d8c3c12a80794f01e9acc065R130

I did not run the 3 tests of mysqldump (as not installed at my system)
The rsync output is a bit different. That may differs from rsync version.

To test final classes this can be used (https://phpunit.readthedocs.io/en/9.5/test-doubles.html).
I did not use it before. Or do you have a better idea?
https://tomasvotruba.com/blog/2019/03/28/how-to-mock-final-classes-in-phpunit/

Improvements:
Flysystem v3 instead of v1.
GitHub Actions instead of Travis (I would suggest to do both in separate PR's).

@kbond
Copy link
Owner

kbond commented Nov 10, 2022

Thanks @Chris53897!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants