feat: drop support of php 7.x, drop support symfony < 5.4 #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
, add support symfony 6, add strong types.
Please check for BC checks of strong types.
I am not sure about these changes. Nullable or not.
https://github.com/kbond/php-backup/compare/master...Chris53897:php-backup:feature/modernize?expand=1#diff-abf1fa77a19f720052b75bc802df0260157b9064d8c3c12a80794f01e9acc065R130
I did not run the 3 tests of
mysqldump
(as not installed at my system)The
rsync
output is a bit different. That may differs from rsync version.To test final classes this can be used (https://phpunit.readthedocs.io/en/9.5/test-doubles.html).
I did not use it before. Or do you have a better idea?
https://tomasvotruba.com/blog/2019/03/28/how-to-mock-final-classes-in-phpunit/
Improvements:
Flysystem v3 instead of v1.
GitHub Actions instead of Travis (I would suggest to do both in separate PR's).