feat: RTL support #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you so much for the PR! I’ll review this as soon as I get time. |
|
Ha, this is actually pretty short and sweet. Merging now. Thanks again. |
|
We’re probably going to want to document these new features (as well as all the older undocumented ones). I’m going to add an issue for that. |
Yeah CSS is admittedly doing all of the heavy lifting here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Instead of asking users to specify a relative direction (
right,left), we can take a page out of CSS logical properties and usestartandendas opposed toleftandright.As an example, here is how tailwindcss handled this recently: tailwindlabs/tailwindcss#10166