Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function within constain offests #381

Open
povi2946 opened this issue Apr 18, 2020 · 5 comments
Open

Function within constain offests #381

povi2946 opened this issue Apr 18, 2020 · 5 comments

Comments

@povi2946
Copy link

Hi,
I would like to request for a feature.
When making planeCoincident constrains I am allowed to set an offset. But I am not allowed to set a formula or use numbers from a spreadsheet.
Also, I usually work in metric but sometimes I need to use inches so I just write 4in or so and it automatically converts within when using other workbenches but in this offset field I am not allowed to enter other system units.. which would be nice.
Thank you

@hfiguiere
Copy link

It's worse. If you enter a non-metric unit offset (like 11+1/2") in the properties, and then you edit the constraints, the offset field containt invalid data.

The property:

image

The constraint edit:

image

I think this issue is about supporting units properly:

  • being able to enter units in the constraint editor
  • honouring the global unit settings and parse them properly with the constraint editor.

Here is my settings for units in FreeCAD to help reproduce

image

@luzpaz
Copy link
Contributor

luzpaz commented Jun 27, 2022

@kbwbe do you have any time to look at this?

@hfiguiere
Copy link

The code in commit 5fda4cd is part of the problem.

From the example above,
user_qty is 1112.0 and user_unit is +/" which lead to setting the suffix on the QDoubleSpinbBox the second time to +/"

@luzpaz
Copy link
Contributor

luzpaz commented Jun 28, 2022

@DanMiel ping

@hfiguiere
Copy link

I have a partial patch that show the proper mm value.

But I think instead of using QDoubleSpinBox, it should use one of the FreeCAD SpinBox. Another problem is that typing something does trigger the solver...

hfiguiere added a commit to hfiguiere/A2plus that referenced this issue Jun 28, 2022
hfiguiere added a commit to hfiguiere/A2plus that referenced this issue Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants