Write config to & read config from JSON file (+ Chromium) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kchawla-pi
commented
Oct 29, 2019
kchawla-pi
commented
- Key for profiles collected is now a tuple of Browser name& profile name, not just profile name.
- CHromium is now an accepted choice when manually adding browsers, but not auto-discovered.
…of-browsers into profile-paths-dict-change * 'master' of https://github.com/kchawla-pi/united-states-of-browsers: Convert db_merge class to function: OOP has no benefit here (#44) Tweak web UI - full page; sticky search box; no ext libs (#43)
- Chromium has been added as supported but not auto-discovered, to enable testing this feature.
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 94.7% 93.48% -1.23%
==========================================
Files 11 11
Lines 378 399 +21
==========================================
+ Hits 358 373 +15
- Misses 20 26 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.