Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus metrics access for keda operator #118

Merged
merged 5 commits into from
Feb 8, 2021
Merged

Add prometheus metrics access for keda operator #118

merged 5 commits into from
Feb 8, 2021

Conversation

oded-dd
Copy link
Contributor

@oded-dd oded-dd commented Jan 27, 2021

No description provided.

@oded-dd
Copy link
Contributor Author

oded-dd commented Jan 27, 2021

Please see the PR, I've added support for podMonitor to a build in set of metrics of the operatorSDK. Thanks to @avivgold098

tomkerkhove
tomkerkhove reviewed Jan 28, 2021
View reviewed changes
keda/Chart.yaml Outdated Show resolved Hide resolved
keda/templates/12-keda-deployment.yaml Show resolved Hide resolved
keda/templates/26-metrics-podmonitor.yaml Show resolved Hide resolved
keda/templates/22-metrics-deployment.yaml Show resolved Hide resolved
@tomkerkhove
Copy link
Member

Thank you for your contribution!

@tomkerkhove tomkerkhove added this to the v2.2.0 milestone Jan 28, 2021
@tomkerkhove
Copy link
Member

Don't forget to:

  • Document these new values in the README of the chart
  • Fix DCO

Thanks for your contribution!

zroubalik
zroubalik approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

I'd love to see this ported to kedacore/keda

@oded-dd
Add prometheus metrics access for keda operator
deaf177 
Signed-off-by: Oded David <oded@coralogix.com>
@oded-dd
Revert versio back to 2.1.0
402b7d0 
Signed-off-by: Oded David <oded@coralogix.com>
@oded-dd
Update README
4389a43 
Signed-off-by: Oded David <oded@coralogix.com>
@oded-dd
Add missing podmonitor for operator
260b916 
Signed-off-by: Oded David <oded@coralogix.com>
@tomkerkhove tomkerkhove mentioned this pull request Feb 3, 2021
Merged
5 tasks
tomkerkhove
tomkerkhove approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for your contribution!

keda/Chart.yaml Outdated Show resolved Hide resolved
keda/templates/12-keda-deployment.yaml Show resolved Hide resolved
@oded-dd @tomkerkhove
Update keda/Chart.yaml
2f72af4 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Oded David <oded@coralogix.com>
@tomkerkhove tomkerkhove merged commit c4d7ea7 into kedacore:master Feb 8, 2021
@tomkerkhove
Copy link
Member

Thank you @oded-dd !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oded-dd @tomkerkhove @zroubalik