Allow image registry override for all keda components

[QuentinBisson]

This PR allow override of the image registry of all keda components so we can use custom image or pull through caching solutions

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• README is updated with new configuration values (if applicable) learn more
• [ ]
  Fixes #

[QuentinBisson]

I have an idea, i'll change that pr monday

[QuentinBisson]

Local testing:

• default values renders:

helm template keda | grep image: | grep keda
          image: "ghcr.io/kedacore/keda:2.12.0"
          image: "ghcr.io/kedacore/keda-metrics-apiserver:2.12.0"
          image: "ghcr.io/kedacore/keda-admission-webhooks:2.12.0"

• edited component registries (require changing the repository but that ensures no breaking changes)

global:
  image:
    # -- Global image registry of KEDA components
    registry: null

image:
  keda:
    # -- Image registry of KEDA operator
    registry: docker.io
    # -- Image name of KEDA operator
    repository: kedacore/keda
    # -- Image tag of KEDA operator. Optional, given app version of Helm chart is used by default
    tag: ""
  metricsApiServer:
    # -- Image registry of KEDA Metrics API Server
    registry: docker.io
    # -- Image name of KEDA Metrics API Server
    repository: kedacore/keda-metrics-apiserver
    # -- Image tag of KEDA Metrics API Server. Optional, given app version of Helm chart is used by default
    tag: ""
  webhooks:
    # -- Image registry of KEDA admission-webhooks
    registry: docker.io
    # -- Image name of KEDA admission-webhooks
    repository: kedacore/keda-admission-webhooks
    # -- Image tag of KEDA admission-webhooks . Optional, given app version of Helm chart is used by default
    tag: ""
  # -- Image pullPolicy for all KEDA components
  pullPolicy: Always

Renders:

helm template keda | grep image: | grep keda
          image: "docker.io/kedacore/keda:2.12.0"
          image: "docker.io/kedacore/keda-metrics-apiserver:2.12.0"
          image: "docker.io/kedacore/keda-admission-webhooks:2.12.0"

• using global with repository change:

global:
  image:
    # -- Global image registry of KEDA components
    registry: quay.io

image:
  keda:
    # -- Image registry of KEDA operator
    registry: docker.io
    # -- Image name of KEDA operator
    repository: kedacore/keda
    # -- Image tag of KEDA operator. Optional, given app version of Helm chart is used by default
    tag: ""
  metricsApiServer:
    # -- Image registry of KEDA Metrics API Server
    registry: docker.io
    # -- Image name of KEDA Metrics API Server
    repository: kedacore/keda-metrics-apiserver
    # -- Image tag of KEDA Metrics API Server. Optional, given app version of Helm chart is used by default
    tag: ""
  webhooks:
    # -- Image registry of KEDA admission-webhooks
    registry: docker.io
    # -- Image name of KEDA admission-webhooks
    repository: kedacore/keda-admission-webhooks
    # -- Image tag of KEDA admission-webhooks . Optional, given app version of Helm chart is used by default
    tag: ""
  # -- Image pullPolicy for all KEDA components
  pullPolicy: Always

Renders:

helm template keda | grep image: | grep keda
          image: "quay.io/kedacore/keda:2.12.0"
          image: "quay.io/kedacore/keda-metrics-apiserver:2.12.0"
          image: "quay.io/kedacore/keda-admission-webhooks:2.12.0"

[QuentinBisson]

@tomkerkhove what do you think about this solution?

[tomkerkhove]

Fine by me - Good idea.

However, we still need to remove the new artifact

[QuentinBisson]

@tomkerkhove I removed the artifact

[tomkerkhove]

Thanks! Sorry for the delay in merging!

[mehraneftekhari99]

The changes are great however they're not pushed to the helm chart registry.
The version in master branch (which includes overridable registry) is 2.12.1. However when you get the exact same version via helm cli, it doesn't have the change!
Something is wrong maybe in build process etc. just wanted to let you know since I spent some time figuring out why it's not working for me.

[JorTurFer]

Hi @mehraneftekhari99
Thanks for reporting it! We haven't cut a release with that feature yet, we will ship it as part of v2.13 during next days