Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note to the deploy.md (on all versions) to make people aware th… #1272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HemeraOne
Copy link

@HemeraOne HemeraOne commented Dec 6, 2023

…at only a single metric server can handle external.metrics.k8s.io per cluster

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

…at only a single metric server can handle external.metrics.k8s.io per cluster

Signed-off-by: Martijn <martijn@squeezely.tech>
@HemeraOne HemeraOne requested a review from a team as a code owner December 6, 2023 17:54
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 5f2b134
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6570b563bc79d60008f14719
😎 Deploy Preview https://deploy-preview-1272--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 6, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove
Copy link
Member

Hi, this is already documented in the FAQ

@JorTurFer
Copy link
Member

FAQ is not totally visible. I think that we can merge the note as users usually don't check the FAQ until something is not working, but they will see the note before installing

@tomkerkhove
Copy link
Member

If we merge it, then we have 2 places to maintain IMO. We should fix FAQ discoverability instead or change the note to just check FAQ to learn more about metric server limitations

@JorTurFer
Copy link
Member

The problems with FAQ is that it doesn't allow linking it. I mean, this note could be just something like:

NOTE: Check api server limitations here: FAQ_SECTION_LINK

But we can't link those items, that's why I'd merge this, at least until we improve the faq

@tomkerkhove
Copy link
Member

Well, we can just fix that @JorTurFer 🤷‍♂️

Every item has an achor assigned and can be linked to: https://keda.sh/docs/faq/#can-i-run-multiple-metric-servers-serving-external-metrics-in-the-same-cluster. Please update the docs to just point to this instead please.

I have opened #1273 to do the same for the categories and #1274 to provide a button to copy.

@JorTurFer
Copy link
Member

is there any option to open the linked anchor?
Default behaviour is browsing to it closed and that's a bit confusing:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants