Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Procedure for Setting Up a Scaler #1415

Closed
wants to merge 39 commits into from

Conversation

shubhusion
Copy link

Description of Changes

Created a procedure for setting up a scaler in KEDA.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Issue Fixed

Fixes kedacore/keda-docs#1368

@shubhusion shubhusion requested a review from a team as a code owner June 28, 2024 08:22
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 965a94e
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66b0fe6bc8e2c200083ffd54
😎 Deploy Preview https://deploy-preview-1415--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ma <shubham27.sharma03@gmail.com>

Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
@shubhusion
Copy link
Author

@tomkerkhove please review this issue

@shubhusion
Copy link
Author

@zroubalik can you please review

@JorTurFer
Copy link
Member

I love the idea of adding this PR ❤️

shubhusion and others added 2 commits July 30, 2024 20:55
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
@shubhusion
Copy link
Author

@JorTurFer @zroubalik I have added a Note for HTTP Add-on.

content/docs/2.14/operate/setupscaler.md Outdated Show resolved Hide resolved
content/docs/2.15/operate/setupscaler.md Show resolved Hide resolved
content/docs/2.14/operate/setupscaler.md Outdated Show resolved Hide resolved
content/docs/2.15/operate/setupscaler.md Show resolved Hide resolved
content/docs/2.15/operate/setupscaler.md Show resolved Hide resolved
content/docs/2.14/operate/setupscaler.md Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this into Getting Started section: https://keda.sh/docs/2.15/

At least for 2.15

shubhusion and others added 6 commits August 5, 2024 19:11
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SHUBHAM SHARMA  <96301987+shubhusion@users.noreply.github.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SHUBHAM SHARMA  <96301987+shubhusion@users.noreply.github.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SHUBHAM SHARMA  <96301987+shubhusion@users.noreply.github.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SHUBHAM SHARMA  <96301987+shubhusion@users.noreply.github.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SHUBHAM SHARMA  <96301987+shubhusion@users.noreply.github.com>
@shubhusion
Copy link
Author

I think we should move this into Getting Started section: https://keda.sh/docs/2.15/

At least for 2.15

Thanks for the review. I will make the necessary changes as specified.

shubhusion and others added 3 commits August 5, 2024 21:55
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
…ma <shubham27.sharma03@gmail.com>

Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
dwelsch-esi and others added 24 commits August 5, 2024 21:56
…edacore#1389)

Co-authored-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-authored-by: Nate W <natew@cncf.io>
Co-authored-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
Co-authored-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
* Add usernameFromEnv support for MYSQL Scaler

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

* Fix typo

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

* Update Readme

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

* Move readme to different folder

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

---------

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: rickbrouwer <75609067+rickbrouwer@users.noreply.github.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
…edacore#1410)

Signed-off-by: Benjamin Woodley <bwoodley012@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
* Update postgres scaler doc to include info about Azure access token auth

Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com>

* minor changes to respect conventions

Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com>

---------

Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
…s proxy (kedacore#1310)

* Add docs for Datadog scaler with Cluster Agent

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* Add optional parameters for the Cluster Agent API server

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* Move new DD docs to 2.14

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* Add missing cluster agent option

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* Add option in the cluster agent to avoid autogenerating DatadogMetric objects

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* fix typo in boolean string type

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* Move Datadog cluster agent docs to 2.15 instead

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* Mark using the Cluster Agent as proxy as experimental

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* datadogMetricsService paramter is mandatory

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

* Establish 1.8.0 as the minimum version of the Datadog Operator required for this

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>

---------

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
…re#1406)

Signed-off-by: Leonardo D'Ippolito <contact@leodip.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: Davide Benvegnu <davide.benvegnu@playstudios.asia>
Signed-off-by: Davide Benvegnù aka CoderDave <davide.benvegnu@outlook.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
…oyed (kedacore#1425)

Signed-off-by: Paul Yu <paul.d.yu@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Signed-off-by: ivan.tuzhilkin <ivan.tuzhilkin@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
…ore#1411)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
@shubhusion
Copy link
Author

shubhusion commented Aug 5, 2024

@JorTurFer I guess I made a mistake while rebasing. I have created a new PR with the required changed. Please review that
PR: #1446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a Procedure for Setting Up a Scaler