Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend selenium-grid scaler #1449

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

extend selenium-grid scaler #1449

wants to merge 3 commits into from

Conversation

rubroboletus
Copy link

Document changes in selenium-grid scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@rubroboletus rubroboletus requested a review from a team as a code owner August 9, 2024 05:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Aug 9, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit cec3bf4
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66d6bb41e45daa000864d69f
😎 Deploy Preview https://deploy-preview-1449--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomkerkhove
Copy link
Member

@rubroboletus Mind mentioning feature link in description so I have full context please?

@rubroboletus
Copy link
Author

Mind mentioning feature link in description so I have full context please?

It documents PR - kedacore/keda#6055

@JorTurFer
Copy link
Member

Could you fix DCO check too?

rubroboletus and others added 3 commits September 3, 2024 07:31
@rubroboletus
describe sessionsPerNode and setSessionsFromHub parameters for seleni…
65f5fda 
…um-grid scaler

Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
@rubroboletus
document sessionBrowserVersion
69c84ea 
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
@rubroboletus @JorTurFer
Update content/docs/2.16/scalers/selenium-grid-scaler.md
cec3bf4 
fix typo

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Robert Hanzlík <robi@junyks.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
@rubroboletus rubroboletus force-pushed the feature/selenium-grid-stereotypes branch from 23bf8ae to cec3bf4 Compare September 3, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubroboletus @tomkerkhove @JorTurFer