Provide documentation for Kubernetes events #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tomkerkhove
requested changes
Jan 30, 2021
There was a problem hiding this comment.
Thanks for these docs!
I've added a remark on kedacore/keda#1523 (comment) so I'll wait with reviewing until we decided on that.
Would you mind moving these docs from v2.0 to v2.2, please, since that's the version where this will be introduced.
ahmelsayed
force-pushed
the
ahmels/events
branch
from
19159b5
to
b0e593f
Compare
tomkerkhove
reviewed
Feb 8, 2021
Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com>
ahmelsayed
force-pushed
the
ahmels/events
branch
from
b0e593f
to
9d0c513
Compare
tomkerkhove
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed ElSayed ahmels@microsoft.com
Closes kedacore/keda#530