Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for non-public cloud support for application insight sc… #729

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Mar 25, 2022

…aler.

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Update application insights scaler documentation.
kedacore/keda#2735

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

…aler.

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@netlify
Copy link

netlify bot commented Mar 25, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 8a2ae92
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/623da1ee3f11e80008f3bd93
😎 Deploy Preview https://deploy-preview-729--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only one comment inline!

content/docs/2.7/scalers/azure-app-insights.md Outdated Show resolved Hide resolved
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks ❤️

@JorTurFer JorTurFer merged commit fd3d2c7 into kedacore:main Mar 25, 2022
@v-shenoy v-shenoy deleted the non-public-clouds-app-insights branch March 25, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants