Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to customize HPA name #768

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Add support to customize HPA name #768

merged 3 commits into from
Jun 20, 2022

Conversation

aviadlevy
Copy link
Contributor

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related to kedacore/keda#3068

@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 040762f
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/628e26848d39190007d6569b
😎 Deploy Preview https://deploy-preview-768--keda.netlify.app/docs/2.8/concepts/scaling-deployments
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only small inline nits

content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
Signed-off-by: aviadlevy <aviadlevy1@gmail.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice and clean - Thanks!

@aviadlevy aviadlevy changed the title Add documentation to custom hpa name Add support to customize HPA name May 25, 2022
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@JorTurFer JorTurFer merged commit 8d748b9 into kedacore:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants