Add document for aws endpoint setting #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phan Duc <phan.duc@moneyforward.co.jp>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
6 tasks
JorTurFer
reviewed
Oct 28, 2022
There was a problem hiding this comment.
I suggested changes to follow the style guide for docs. There is also missing the change in cloudwatch scaler docs
Signed-off-by: Phan Duc <phan.duc@moneyforward.co.jp>
yuyuvn
force-pushed
the
add-aws-endpoint-docs
branch
from
03cc525
to
ac588b4
Compare
yuyuvn
commented
Oct 28, 2022
|
Fixed style and add docs for cloudwatch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add document for aws endpoint setting
kedacore/keda#3779
Checklist
Fixes kedacore/keda#3337