Change the argument name to

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

pkg/scalers/external_scaler.go

@@ -33,14 +33,14 @@ type externalPushScaler struct {
 }
 
 type externalScalerMetadata struct {
-	scalerAddress      string
-	tlsCertFile        string
-	originalMetadata   map[string]string
-	scalerIndex        int
-	caCert             string
-	tlsClientCert      string
-	tlsClientKey       string
-	insecureSkipVerify bool
+	scalerAddress    string
+	tlsCertFile      string
+	originalMetadata map[string]string
+	scalerIndex      int
+	caCert           string
+	tlsClientCert    string
+	tlsClientKey     string
+	unsafeSsl        bool
 }
 
 type connectionGroup struct {
@@ -130,13 +130,13 @@ func parseExternalScalerMetadata(config *ScalerConfig) (externalScalerMetadata,
 		meta.tlsClientKey = val
 	}
 
-	meta.insecureSkipVerify = false
-	if val, ok := config.TriggerMetadata["insecureSkipVerify"]; ok && val != "" {
+	meta.unsafeSsl = false
+	if val, ok := config.TriggerMetadata["unsafeSsl"]; ok && val != "" {
 		boolVal, err := strconv.ParseBool(val)
 		if err != nil {
 			return meta, fmt.Errorf("failed to parse insecureSkipVerify value. Must be either true or false")
 		}
-		meta.insecureSkipVerify = boolVal
+		meta.unsafeSsl = boolVal
 	}
 	// Add elements to metadata
 	for key, value := range config.TriggerMetadata {
@@ -314,7 +314,7 @@ func getClientForConnectionPool(metadata externalScalerMetadata, logger logr.Log
 			return grpc.Dial(metadata.scalerAddress, grpc.WithTransportCredentials(creds))
 		}
 
-		tlsConfig, err := util.NewTLSConfig(metadata.tlsClientCert, metadata.tlsClientKey, metadata.caCert, metadata.insecureSkipVerify)
+		tlsConfig, err := util.NewTLSConfig(metadata.tlsClientCert, metadata.tlsClientKey, metadata.caCert, metadata.unsafeSsl)
 		if err != nil {
 			return nil, err
 		}

pkg/scalers/external_scaler_test.go

@@ -79,8 +79,8 @@ func TestExternalScalerParseMetadata(t *testing.T) {
 			t.Error("Expected success but got error", err)
 		}
 
-		if testData.metadata["insecureSkipVerify"] == "true" && !metadata.insecureSkipVerify {
-			t.Error("Expected insecureSkipVerify to be true but got", metadata.insecureSkipVerify)
+		if testData.metadata["unsafeSsl"] == "true" && !metadata.unsafeSsl {
+			t.Error("Expected unsafeSsl to be true but got", metadata.unsafeSsl)
 		}
 		if testData.isError && err == nil {
 			t.Error("Expected error but got success")