Remove deprecated field rolloutStrategy

[JorTurFer]

Proposal

In #3338 we introduced a new section that extends this.
We need to remove the deprecated rolloutStrategy

Use-Case

No response

Anything else?

No response

[Ritikaa96]

Hi, @JorTurFer , I'd like to take this up. What I understood is we have to remove rolloutStartegy from :

• apis/keda/v1alpha1/scaledjob_types.go
• controllers/keda/scaledjob_controller.go
• config/crd/bases/keda.sh_scaledjobs.yaml

There is no mention of rolloutStrategy anywhere else so we are safe to deprecate it through these.

[tomkerkhove]

Thanks! Unfortunately we cannot do this yet as this is a breaking change and we have to wait for KEDA 3.X.

[Ritikaa96]

Thanks! Unfortunately we cannot do this yet as this is a breaking change and we have to wait for KEDA 3.X.

oh! alright! seems like a rational approach ! thanks for the quick reply :)

[tomkerkhove]

No problem and thanks for looking for contribution items!

[zroubalik]

Honestly I think we can drop it :D it's change in crd which is v1alpha1.

[JorTurFer]

IMO, we should keep at least 1 version the old code with a warning to avoid breaking changes, giving some time (2-3 months) to update the manifest. Something like, WARNING: the field XXX has been deprecated in favor of YYY and will be removed in vZZZZ(like k8s does)

[JorTurFer]

I mean, I agree with removing the fields, but giving info to the users and time to update, we could improve the user experience. In the case of we notify it and they don't update their manifest, it's totally their fault.
Anyway, we should document this also in kedacore/governance#70

[zroubalik]

Absolutely, this is the way.

[tomkerkhove]

Which is a good reminder to ask to re-review open comments on kedacore/governance#70 :)

[JorTurFer]

Based on our deprecation policies, I guess this should be removed in v2.10

[tomkerkhove]

@JorTurFer No, it needs a new API version to remove it as it's part of our CRD AFAIK

[JorTurFer]

true