Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Provide policy on breaking changes & deprecations in KEDA #70

Merged
merged 9 commits into from
Dec 6, 2022

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Aug 26, 2022

Provide policy on breaking changes & deprecations in KEDA

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to #68

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
tomkerkhove and others added 2 commits September 12, 2022 09:28
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove
Copy link
Member Author

@JorTurFer @zroubalik gentle reminder

DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Show resolved Hide resolved
DEPRECATIONS.md Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member Author

Setting up meeting to discuss open items

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Copy link
Member

@jeffhollan jeffhollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thank you @tomkerkhove

DEPRECATIONS.md Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
DEPRECATIONS.md Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal looks good, but I have finally found out what is the only concern I am having. We should be able to mark some features as experimental/alpha/tech preview... in order to try new things but withough locking us into backwards compatibility requirement.

This way we can try new things and users has clear idea that it is not stable feature.

WDYT?

@JorTurFer
Copy link
Member

The proposal looks good, but I have finally found out what is the only concern I am having. We should be able to mark some features as experimental/alpha/tech preview... in order to try new things but withough locking us into backwards compatibility requirement.

This way we can try new things and users has clear idea that it is not stable feature.

WDYT?

It's a good idea, but I'd just add it as a note in the docs, or a table somewhere, simplest as possible

@tomkerkhove
Copy link
Member Author

The proposal looks good, but I have finally found out what is the only concern I am having. We should be able to mark some features as experimental/alpha/tech preview... in order to try new things but withough locking us into backwards compatibility requirement.

This way we can try new things and users has clear idea that it is not stable feature.

WDYT?

It's a good idea, but I'd just add it as a note in the docs, or a table somewhere, simplest as possible

We can't do that @JorTurFer , this has to be baked in to the policy. @zroubalik makes sense. Do you want to take a stab at writing a section on this?

@JorTurFer
Copy link
Member

We can't do that @JorTurFer , this has to be baked in to the policy. @zroubalik makes sense. Do you want to take a stab at writing a section on this?

no no, I meant to reflect it in this policy because we should explain these things, but making the implementation simplest as possible, something like adding notes in the feature docs or all together in a section, but now having something super sophisticated for this.

@zroubalik
Copy link
Member

The proposal looks good, but I have finally found out what is the only concern I am having. We should be able to mark some features as experimental/alpha/tech preview... in order to try new things but withough locking us into backwards compatibility requirement.
This way we can try new things and users has clear idea that it is not stable feature.
WDYT?

It's a good idea, but I'd just add it as a note in the docs, or a table somewhere, simplest as possible

We can't do that @JorTurFer , this has to be baked in to the policy. @zroubalik makes sense. Do you want to take a stab at writing a section on this?

I can, but no sooner than in a week. I have a ton of stuff to do now 😄

@tomkerkhove
Copy link
Member Author

That's OK - Thanks!

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

DEPRECATIONS.md Show resolved Hide resolved
@tomkerkhove
Copy link
Member Author

Great! @ahmelsayed @jeffhollan can you take a last look please?

@tomkerkhove
Copy link
Member Author

We have a majority vote, great to see this getting merged 🎉

@tomkerkhove tomkerkhove merged commit 3160930 into main Dec 6, 2022
@tomkerkhove tomkerkhove deleted the deprecation-breaking-change branch December 6, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants