Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Add MetricsAPIScaler #1026

Merged
merged 7 commits into from
Sep 3, 2020
Merged

[v2] Add MetricsAPIScaler #1026

merged 7 commits into from
Sep 3, 2020

Conversation

turbaszek
Copy link
Contributor

@turbaszek turbaszek commented Aug 22, 2020 •
edited
Loading

Closes: #929

TODO:

Checklist

@turbaszek turbaszek force-pushed the feature/http-scaler branch 2 times, most recently from 545a94e to 14113a0 Compare August 22, 2020 19:43
@turbaszek turbaszek marked this pull request as ready for review August 22, 2020 19:49
@tomkerkhove
Copy link
Member

Can you target v2 please?

tomkerkhove
tomkerkhove requested changes Aug 24, 2020
View reviewed changes
pkg/scalers/http_scaler.go Outdated Show resolved Hide resolved
pkg/handler/scale_handler.go Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

zroubalik commented Aug 24, 2020 •
edited
Loading

This is great, but could you please open this PR against v2 branch? We don't expect to bring any new features in v1

@turbaszek turbaszek changed the base branch from master to v2 August 24, 2020 08:59
@zroubalik zroubalik changed the title Add HTTPScaler [v2] Add HTTPScaler Aug 24, 2020
zroubalik
zroubalik requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to start creating docs for this scaler, so we can fully understand what is the expected behavior

pkg/scalers/http_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/http_scaler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scalers/http_scaler.go Outdated Show resolved Hide resolved
@turbaszek turbaszek mentioned this pull request Aug 24, 2020
Merged
4 tasks
@turbaszek turbaszek mentioned this pull request Aug 25, 2020
Merged
@turbaszek turbaszek changed the title [v2] Add HTTPScaler [v2] Add MetricAPIScaler Aug 25, 2020
@turbaszek turbaszek changed the title [v2] Add MetricAPIScaler [v2] Add MetricsAPIScaler Aug 25, 2020
@turbaszek
Copy link
Contributor Author

@zroubalik @ahmelsayed @lonnix I opened PR with docs kedacore/keda-docs#239. Would be awesome to hear your opinion and questions. As the next step, I would like to add authentication option as discussed in the original issue.

@turbaszek
Add HTTPScaler
1a5c4b5 
Closes: kedacore#929
Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek
Adjust code to v2 version
e9bc920 
Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek
Fix isActive function
d66f0d9 
Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek
Rename the scaler to metricsAPIScaler
c951f4a 
Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek
Apply code formatting
3870027 
Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek
Check API health when creating new scaler
7188147 
Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek
Use gjson instead of fixed open-api spec
2c159dc 
Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek
Copy link
Contributor Author

@tomkerkhove @zroubalik @ahmelsayed please take a look at the last changes. I've updated also docs PR kedacore/keda-docs#239

In the meantime, I'm trying to build and use custom KEDA images...

@ahmelsayed ahmelsayed merged commit ea116fc into kedacore:v2 Sep 3, 2020
@turbaszek turbaszek mentioned this pull request Sep 3, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@zroubalik zroubalik Awaiting requested review from zroubalik

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External metric provider via HTTP
4 participants
@turbaszek @tomkerkhove @zroubalik @ahmelsayed