[v2] use go 1.15 #1046
Merged
[v2] use go 1.15 #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
commented
Aug 26, 2020
| @@ -1,6 +1,6 @@ | |||
| module github.com/kedacore/keda | |||
|
|
|||
| go 1.13 | |||
There was a problem hiding this comment.
This is a regression that I by accident brought by migrating to operator-sdk 1.0.0 #1007.
We are already on 1.14
There was a problem hiding this comment.
If we don't go with 1.15, I'll open another PR to fix the version to the correct one (1.14)
There was a problem hiding this comment.
going to 1.15 sounds good to me.
ahmelsayed
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
Go 1.15 was released and brings some nice internal optimizations, I think it is good time to move to the new version