fix codegen generation a verification on GH Actions #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
|
Please note, this will be failing till clientset in the repo is not fixed, eg. this pr merged: #1486 |
ahmelsayed
approved these changes
Jan 8, 2021
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
At some environments (eg. GitHub Actions), due to $GOPATH setting, the codegen output might not be at the expected path in the project repo, therefore we should force the output to the specific directory (see --output-base) we need to handle (move) the generated files to the correct location in the repo then.
Without this change, we weren't able to catch neccessary updates in the generated code (for example as in #1486).