Show min/max replica count when using kubectl get scaledobject #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
coderanger
reviewed
Jan 25, 2021
tomkerkhove
reviewed
Jan 25, 2021
| @@ -28,6 +28,12 @@ spec: | |||
| - jsonPath: .spec.triggers[*].type | |||
| name: Triggers | |||
| type: string | |||
| - jsonPath: .spec.minReplicaCount | |||
There was a problem hiding this comment.
We'll have to update our Helm chart as well; taking mental note
…ectl get so Signed-off-by: Ritikaa96 <ritika@india.nec.com>
zroubalik
reviewed
Jan 26, 2021
There was a problem hiding this comment.
Looking good, @Ritikaa96 could you please add the same for ScaledJob?
…sing kubectl get scaledjob Signed-off-by: Ritikaa96 <ritika@india.nec.com>
|
@tomkerkhove @zroubalik @coderanger I've shuffled the min/max in scaledObject and added min/max for scaledJob. PTAL. |
zroubalik
reviewed
Jan 26, 2021
There was a problem hiding this comment.
@Ritikaa96 could you please update Changelog (improvements section) :)
Sure. |
…bject Signed-off-by: Ritikaa96 <ritika@india.nec.com>
zroubalik
reviewed
Jan 26, 2021
…get scaledobject/scaledjob Signed-off-by: Ritikaa96 <ritika@india.nec.com>
|
Thanks @Ritikaa96! |
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
…job (kedacore#1534) Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Rodolfodc
pushed a commit
to sidilabs/keda
that referenced
this pull request
Mar 11, 2021
…job (kedacore#1534) Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ritikaa96 ritika@india.nec.com
Checklist
Fixes #1410