Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Blob Scaler - Fix multiple scalers with the same blobContainerName #1816

Merged
merged 2 commits into from
May 24, 2021
Merged

Azure Blob Scaler - Fix multiple scalers with the same blobContainerName #1816

merged 2 commits into from
May 24, 2021

Conversation

MattJeanes
Copy link
Contributor

@MattJeanes MattJeanes commented May 20, 2021 •
edited
Loading

Include blobPrefix in metricName and allow custom metricName for azure-blob scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable): Add metricName to azure-blob scaler keda-docs#451
  • Changelog has been updated

Fixes #1815

This was referenced May 20, 2021
Merged
Closed
@MattJeanes
include blobPrefix in metricName and allow custom metricName for azur…
f9dd03a 
…e-blob scaler

Signed-off-by: Matt Jeanes <mattjeanes23@gmail.com>
@MattJeanes MattJeanes force-pushed the azure-blob-metric-fix branch 2 times, most recently from 63e27fe to f5e418c Compare May 20, 2021 16:26
@MattJeanes
Update changelog for PR 1816
30a3b41 
Signed-off-by: Matt Jeanes <mattjeanes23@gmail.com>
zroubalik
zroubalik approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MattJeanes !

@zroubalik zroubalik merged commit 6565347 into kedacore:main May 24, 2021
@MattJeanes MattJeanes deleted the azure-blob-metric-fix branch January 15, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Blob Scaler fails when using multiple triggers with different blobPrefixes
2 participants
@MattJeanes @zroubalik