Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: READY and ACTIVE fields of ScaledJob to show status. #1855

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Fix: READY and ACTIVE fields of ScaledJob to show status. #1855

merged 4 commits into from
Jun 2, 2021

Conversation

Shubham82
Copy link
Contributor

@Shubham82 Shubham82 commented Jun 2, 2021 •
edited
Loading

Signed-off-by: Shubham Kuchhal shubham.kuchhal@india.nec.com

Fix the READY AND ACTIVE fields of ScaledJob to show Status before and after scaling when we run kubectl get sj. and also replace ScaledObject to ScaledJob in comments and error message for ScaledJob.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Changelog has been updated

Fixes #1849

@Shubham82
Fix: READY AND ACTIVE fields of ScaledJob to show status.
58a252f 
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
@Shubham82 Shubham82 mentioned this pull request Jun 2, 2021
Closed
@Shubham82
Copy link
Contributor Author

Hi @tomkerkhove @zroubalik @ahmelsayed
PTAL!

zroubalik
zroubalik reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor nit and could you please add this to the changelog? (Improvements section)

controllers/scaledjob_controller.go Outdated Show resolved Hide resolved
@zroubalik zroubalik changed the title Fix: READY AND ACTIVE fields of ScaledJob to show status. Fix: READY and ACTIVE fields of ScaledJob to show status. Jun 2, 2021
@Shubham82
Change reconcileJobType implemets to reconcileScaledJob implements in…
4c695a2 
… comment.

Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
@Shubham82
Update the changelog.
c317580 
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
zroubalik
zroubalik requested changes Jun 2, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Shubham82
Move this PR link to Unreleased in CHANGELOG
08ea5f7 
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
zroubalik
zroubalik approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Shubham82

@zroubalik zroubalik merged commit 729c6cb into kedacore:main Jun 2, 2021
@zroubalik zroubalik added this to the v2.4.0 milestone Jul 14, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@Shubham82 @nilayasiktoprak
Fix: READY and ACTIVE fields of ScaledJob to show status. (kedacore#1855
d80447e 
)

Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

READY AND ACTIVE fields of ScaledJob are empty when we run "kubectl get sj"
2 participants
@Shubham82 @zroubalik