Don't panic when HashiCorp Vault path doesn't exist #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
changed the title
tomkerkhove
approved these changes
Jun 7, 2021
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
If HashiCorp Vault is being used and the input path is non existent, the library for reading the secret doesn't return error. In this case we need to handle this case and return error, instead of panic caused by accessing non existent secret.
Checklist
Fixes #1864