Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback functionality #1910

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Add fallback functionality #1910

merged 1 commit into from
Jul 14, 2021

Conversation

mishamo
Copy link
Contributor

@mishamo mishamo commented Jun 28, 2021 •
edited
Loading

Signed-off-by: misha mishamo@gmail.com

Changes as agreed per #1872

Checklist

Fixes #1872

zroubalik
zroubalik reviewed Jul 7, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good! I have minor comments though.

The thorough tests are awesome!

api/v1alpha1/scaledobject_types.go Show resolved Hide resolved
controllers/scaledobject_controller.go Show resolved Hide resolved
pkg/provider/provider.go Show resolved Hide resolved
@zroubalik zroubalik requested a review from coderanger July 9, 2021 09:00
zroubalik
zroubalik approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Could you please rebase this PR?

@zroubalik zroubalik added this to the v2.4.0 milestone Jul 14, 2021
@zroubalik
Copy link
Member

@mishamo FYI the tests have failed

@mishamo
Add fallback functionality
925c7ed 
Signed-off-by: misha <mishamo@gmail.com>
@zroubalik zroubalik merged commit cc6a5bb into kedacore:main Jul 14, 2021
@zroubalik
Copy link
Member

@mishamo thanks a lot for the contribution 🎉

@tomkerkhove
Copy link
Member

Thank you, very nice feature!

@zroubalik zroubalik mentioned this pull request Aug 17, 2021
Merged
2 tasks
@JorTurFer JorTurFer mentioned this pull request Aug 23, 2021
Open
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@mishamo @nilayasiktoprak
Add fallback functionality (kedacore#1910)
8196dc2 
Signed-off-by: misha <mishamo@gmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bez625 Bez625 Bez625 left review comments

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@coderanger coderanger Awaiting requested review from coderanger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Fallback wrapper scaler
4 participants
@mishamo @zroubalik @tomkerkhove @Bez625