Metrics APIServer: Add ratelimiting parameters to override client #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zroubalik
changed the title
zroubalik
reviewed
Jul 12, 2021
There was a problem hiding this comment.
Looking good, could you please document this in a new section in: https://keda.sh/docs/2.3/operate/cluster/ ?
And there is a minor linter problem in the code - it is not formatted.
…ide of client defaults Signed-off-by: Chris Berry <bez625@gmail.com>
Merged
2 tasks
|
Thanks @zroubalik for your feedback. I have updated the PR |
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
…ide of client defaults (kedacore#1944) Signed-off-by: Chris Berry <bez625@gmail.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rate limiting parameters to the Keda metrics apiserver to allow override of client defaults
Signed-off-by: Chris Berry bez625@gmail.com
Adding flags to the metrics api server main so that we can override the default client QPS and burst. This allows us to enable higher throughput of requests when Kubernetes HPA sync rate is higher frequency than default client limits.
Checklist
we couldn't find an appropriate place to add these in the documentation. If you would like something to be added please let us know.As suggested we have updated docs here New cluster operations docs describing adapter Kubeclient config params keda-docs#485