Improve Redis support #2181

jerbob92 · 2021-10-11T13:12:05Z

This pull request:

Upgrades the Go Redis library from v6.15.9 to v8.11.4
Adds support for username, for ACL support in Redis 6+
Adds support for Redis Sentinel

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)
Tests have been added
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Changelog has been updated

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

…ange if statements to switch statements Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

tomkerkhove · 2021-10-12T06:14:05Z

Thanks for the PR, can you also create an issue please?

Typically we discuss things on issues first but it's OK in this case.

jerbob92 · 2021-10-12T07:13:08Z

Thanks for the PR, can you also create an issue please?

Typically we discuss things on issues first but it's OK in this case.

Done #2182

zroubalik

Looking good, I have a few questions:

does the updated Redis Library still support the old versions? (ie. we are backwards compatible)
I am not Redis expert, but if I am not mistaken Redis Sentinel is basically HA solution for Redis, do you think that it makes sense to create e2e test for Redis Sentinel Scalers similar to Redis existing ones? https://github.com/kedacore/keda/tree/main/tests

jerbob92 · 2021-10-12T09:22:31Z

Looking good, I have a few questions:

does the updated Redis Library still support the old versions? (ie. we are backwards compatible)

Yes, you can check here: https://github.com/go-redis/redis/blob/master/CHANGELOG.md
They only added improvements and feature additions. Main reason why they changed major versions is Go module support and Client API changes.

I am not Redis expert, but if I am not mistaken Redis Sentinel is basically HA solution for Redis, do you think that it makes sense to create e2e test for Redis Sentinel Scalers similar to Redis existing ones? https://github.com/kedacore/keda/tree/main/tests

Yes Sentinel is a HA solution for Redis, ik keeps track of which server is the master, and if there is a failure it knows how to recover and select a new master. When you connect using Sentinel, the client asks which server is the master at that point in time and then connects to that master.

I was not aware of the e2e tests, I only noticed the go tests, but yes it would be a good idea to add e2e tests, will look into that!

zroubalik · 2021-10-12T10:26:22Z

Looking good, I have a few questions:

does the updated Redis Library still support the old versions? (ie. we are backwards compatible)

Yes, you can check here: https://github.com/go-redis/redis/blob/master/CHANGELOG.md They only added improvements and feature additions. Main reason why they changed major versions is Go module support and Client API changes.

I am not Redis expert, but if I am not mistaken Redis Sentinel is basically HA solution for Redis, do you think that it makes sense to create e2e test for Redis Sentinel Scalers similar to Redis existing ones? https://github.com/kedacore/keda/tree/main/tests

Yes Sentinel is a HA solution for Redis, ik keeps track of which server is the master, and if there is a failure it knows how to recover and select a new master. When you connect using Sentinel, the client asks which server is the master at that point in time and then connects to that master.

I was not aware of the e2e tests, I only noticed the go tests, but yes it would be a good idea to add e2e tests, will look into that!

OK, makes sense, thanks!

jerbob92 · 2021-10-12T11:15:17Z

@zroubalik
I'm quite far with the e2e tests, but I'm a little puzzled where these images are coming from:

goku321/redis-cluster-list:v1.7
goku321/redis-cluster-streams:v2.5
kedacore/tests-redis-lists:824031e
abhirockzz/redis-streams-producer

zroubalik · 2021-10-12T11:36:40Z

The sources should be here: https://github.com/kedacore/test-tools/tree/master/e2e/images/redis

But the reference to https://github.com/orgs/kedacore/packages?repo_name=test-tools registry hasnt been changed yet in the current redis e2e tests. Would you mind changing it in your PR?

I hope that all sources are there.
Thanks!

jerbob92 · 2021-10-12T11:39:29Z

The sources should be here: https://github.com/kedacore/test-tools/tree/master/e2e/images/redis

But the reference to https://github.com/orgs/kedacore/packages?repo_name=test-tools registry hasnt been changed yet in the current redis e2e tests. Would you mind changing it in your PR?

I hope that all sources are there. Thanks!

Thanks!
Looks like the sources are only there for the lists, the other one is just a one-line Dockerfile with a reference to abhirockzz/redis-streams-consumer

zroubalik · 2021-10-12T12:10:30Z

@abhirockzz do you have the sources for abhirockzz/redis-streams-consumer image? We would like to store them on https://github.com/kedacore/test-tools/tree/master/e2e/images/redis/consumer thanks!

jerbob92 · 2021-10-12T12:12:07Z

Please note that the following images are not in there at all:
goku321/redis-cluster-list:v1.7
goku321/redis-cluster-streams:v2.5

@goku321

arschles

Overall this looks excellent.

My one, fairly large all request is to remove the global var ctx = context.Background() and add it as a parameter to whatever function(s) requires a context.Context. I noted a few (bot not all) places where that would be appropriate

pkg/scalers/redis_scaler.go

jerbob92 · 2021-10-13T07:40:25Z

Overall this looks excellent.

My one, fairly large all request is to remove the global var ctx = context.Background() and add it as a parameter to whatever function(s) requires a context.Context. I noted a few (bot not all) places where that would be appropriate

I have updated some of the code to use the context that Keda provides (in IsActive() and GetMetrics()) . The other places still use context.Background() since Keda doesn't provide a context in buildScaler/buildScalers/GetScalers. There is a context at some point when you go back more, that could eventually be passed into the create*Scaler methods, but that requires a significant rewrite of code outside the Redis code so it would probably good to create a separate task to implement context correctly in the codebase and pass it to all scalers since Redis probably isn't the only scaler that allows using context.

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

zroubalik · 2021-10-13T07:54:43Z

Overall this looks excellent.
My one, fairly large all request is to remove the global var ctx = context.Background() and add it as a parameter to whatever function(s) requires a context.Context. I noted a few (bot not all) places where that would be appropriate

I have updated some of the code to use the context that Keda provides (in IsActive() and GetMetrics()) . The other places still use context.Background() since Keda doesn't provide a context in buildScaler/buildScalers/GetScalers. There is a context at some point when you go back more, that could eventually be passed into the create*Scaler methods, but that requires a significant rewrite of code outside the Redis code so it would probably good to create a separate task to implement context correctly in the codebase and pass it to all scalers since Redis probably isn't the only scaler that allows using context.

I agree, we should tackle the context propagation in a separate task. @jerbob92 would you mind opening an issue for this? Thanks!

jerbob92 · 2021-10-13T08:28:47Z

Overall this looks excellent.
My one, fairly large all request is to remove the global var ctx = context.Background() and add it as a parameter to whatever function(s) requires a context.Context. I noted a few (bot not all) places where that would be appropriate

I have updated some of the code to use the context that Keda provides (in IsActive() and GetMetrics()) . The other places still use context.Background() since Keda doesn't provide a context in buildScaler/buildScalers/GetScalers. There is a context at some point when you go back more, that could eventually be passed into the create*Scaler methods, but that requires a significant rewrite of code outside the Redis code so it would probably good to create a separate task to implement context correctly in the codebase and pass it to all scalers since Redis probably isn't the only scaler that allows using context.

I agree, we should tackle the context propagation in a separate task. @jerbob92 would you mind opening an issue for this? Thanks!

Done: #2190

Just FYI:
I have added the e2e tests, but I'm still waiting for the source code of the other e2e tests to finish it up. However, all checks are green now, while I know my e2e tests don't work yet. Shouldn't pull requests be e2e tested too?

zroubalik · 2021-10-13T09:44:41Z

@jerbob92 currently we are not running e2e tests on PRs, they run after the merge on main and then there's nightly run.

arschles

@jerbob92 thanks for creating #2190 !

goku321 · 2021-10-23T11:01:07Z

Please note that the following images are not in there at all: goku321/redis-cluster-list:v1.7 goku321/redis-cluster-streams:v2.5

@goku321

Hi @jerbob92 sorry for the late reply. The mentioned images are available. See the screenshot below

Are you still having problems accessing them or is it resolved? Thanks for your patience.

zroubalik · 2021-10-23T11:40:23Z

Please note that the following images are not in there at all: goku321/redis-cluster-list:v1.7 goku321/redis-cluster-streams:v2.5
@goku321

Hi @jerbob92 sorry for the late reply. The mentioned images are available. See the screenshot below

Are you still having problems accessing them or is it resolved? Thanks for your patience.

@goku321 we are looking for sources of those images, we would like to host the sources here: https://github.com/kedacore/test-tools

@jerbob92 would like to extend your images for testing the feature from this PR.

Thanks!

goku321 · 2021-10-23T12:38:25Z

Hello @zroubalik, this makes sense. Now I realize I had this thing in mind before but I got caught up with other stuff. I'll put the sources in the required place.

goku321 · 2021-10-23T18:10:35Z

@zroubalik @jerbob92 Here's the source for above mentioned images: kedacore/test-tools#21

Please do let me know if I can help with anything else 🙂

zroubalik · 2021-10-25T09:20:56Z

@jerbob92 e2e tests sources are up, feel free to update them as it is needed to. Then please use images hosted in ghcr.io: https://github.com/orgs/kedacore/packages?tab=packages&q=redis

Thanks!

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

jerbob92 · 2021-11-01T14:40:29Z

@zroubalik What do I have to do to get the images from test-tools? I'd like to run the e2e tests. The MR in test-tools has been merged but the new packages don't show up.

zroubalik · 2021-11-01T14:45:54Z

@jerbob92 I can see the images here: https://github.com/orgs/kedacore/packages?tab=packages&q=sent

Do you need anything else?

zroubalik · 2021-11-01T14:46:53Z

@jerbob92 the e2e tests are running here: https://github.com/kedacore/keda/runs/4068547564?check_suite_focus=true

jerbob92 · 2021-11-01T14:47:20Z

@jerbob92 I can see the images here: https://github.com/orgs/kedacore/packages?tab=packages&q=sent

Do you need anything else?

They don't show up for me. Are they private by default?

zroubalik · 2021-11-01T14:48:11Z

@jerbob92 you are right, sorry I missed that. Fixing now, thanks!

zroubalik · 2021-11-01T15:04:27Z

2021-11-01T14:59:31.2034189Z >>> scalers/redis-sentinel-lists.test.ts.log <<<
2021-11-01T14:59:31.2034870Z 
2021-11-01T14:59:31.2035611Z namespace/redis-sentinel created
2021-11-01T14:59:31.2036545Z "bitnami" already exists with the same configuration, skipping
2021-11-01T14:59:31.2037742Z NAME: redis-sentinel
2021-11-01T14:59:31.2038501Z LAST DEPLOYED: Mon Nov  *** ***4:34:06 202***
2021-11-01T14:59:31.2039398Z NAMESPACE: redis-sentinel
2021-11-01T14:59:31.2040110Z STATUS: deployed
2021-11-01T14:59:31.2040728Z REVISION: ***
2021-11-01T14:59:31.2041304Z TEST SUITE: None
2021-11-01T14:59:31.2041875Z NOTES:
2021-11-01T14:59:31.2042444Z CHART NAME: redis
2021-11-01T14:59:31.2043062Z CHART VERSION: ***5.5.3
2021-11-01T14:59:31.2043683Z APP VERSION: 6.2.6
2021-11-01T14:59:31.2044066Z 
2021-11-01T14:59:31.2044806Z ** Please be patient while the chart is being deployed **
2021-11-01T14:59:31.2045375Z 
2021-11-01T14:59:31.2046252Z Redis&trade; can be accessed via port 6379 on the following DNS name from within your cluster:
2021-11-01T14:59:31.2047099Z 
2021-11-01T14:59:31.2048565Z     redis-sentinel.redis-sentinel.svc.cluster.local for read only operations
2021-11-01T14:59:31.2049675Z 
2021-11-01T14:59:31.2050782Z For read/write operations, first access the Redis&trade; Sentinel cluster, which is available in port 26379 using the same domain name above.
2021-11-01T14:59:31.2051682Z 
2021-11-01T14:59:31.2052011Z 
2021-11-01T14:59:31.2052311Z 
2021-11-01T14:59:31.2052878Z To get your password run:
2021-11-01T14:59:31.2053301Z 
2021-11-01T14:59:31.2054833Z     export REDIS_PASSWORD=$(kubectl get secret --namespace redis-sentinel redis-sentinel -o jsonpath="{.data.redis-password}" | base64 --decode)
2021-11-01T14:59:31.2056190Z 
2021-11-01T14:59:31.2056773Z To connect to your Redis&trade; server:
2021-11-01T14:59:31.2057230Z 
2021-11-01T14:59:31.2057886Z ***. Run a Redis&trade; pod that you can use as a client:
2021-11-01T14:59:31.2058366Z 
2021-11-01T14:59:31.2060007Z    kubectl run --namespace redis-sentinel redis-client --restart='Never'  --env REDIS_PASSWORD=$REDIS_PASSWORD  --image docker.io/bitnami/redis:6.2.6-debian-***0-r2*** --command -- sleep infinity
2021-11-01T14:59:31.2061125Z 
2021-11-01T14:59:31.2061764Z    Use the following command to attach to the pod:
2021-11-01T14:59:31.2062240Z 
2021-11-01T14:59:31.2063000Z    kubectl exec --tty -i redis-client \
2021-11-01T14:59:31.2063935Z    --namespace redis-sentinel -- bash
2021-11-01T14:59:31.2064405Z 
2021-11-01T14:59:31.2064988Z 2. Connect using the Redis&trade; CLI:
2021-11-01T14:59:31.2066130Z    redis-cli -h redis-sentinel -p 6379 -a $REDIS_PASSWORD # Read only operations
2021-11-01T14:59:31.2067425Z    redis-cli -h redis-sentinel -p 26379 -a $REDIS_PASSWORD # Sentinel access
2021-11-01T14:59:31.2068028Z 
2021-11-01T14:59:31.2068841Z To connect to your database from outside the cluster execute the following commands:
2021-11-01T14:59:31.2069485Z 
2021-11-01T14:59:31.2070511Z     kubectl port-forward --namespace redis-sentinel svc/redis-sentinel 6379:6379 &
2021-11-01T14:59:31.2071704Z     redis-cli -h ***27.0.0.*** -p 6379 -a $REDIS_PASSWORD
2021-11-01T14:59:31.2072448Z Waiting for 3 pods to be ready...
2021-11-01T14:59:31.2073134Z Waiting for 2 pods to be ready...
2021-11-01T14:59:31.2074000Z error: timed out waiting for the condition
2021-11-01T14:59:31.2074631Z ***0.0.***86.235
2021-11-01T14:59:31.2075590Z namespace/redis-sentinel-lists-test created
2021-11-01T14:59:31.2076778Z secret/redis***
2021-11-01T14:59:31.2078512Z triggerauthentication.keda.sh/keda-redis-sentinel-list-triggerauth created
2021-11-01T14:59:31.2080064Z secret/redis-config created
2021-11-01T14:59:31.2081915Z triggerauthentication.keda.sh/keda-redis-sentinel-list-triggerauth-host-port created
2021-11-01T14:59:31.2083957Z deployment.apps/redis-worker-test-hostport created
2021-11-01T14:59:31.2085497Z scaledobject.keda.sh/redis-worker-test-hostport created
2021-11-01T14:59:31.2087000Z deployment.apps/redis-worker-test-address created
2021-11-01T14:59:31.2088515Z scaledobject.keda.sh/redis-worker-test-address created
2021-11-01T14:59:31.2090285Z deployment.apps/redis-worker-test-hostport-triggerauth created
2021-11-01T14:59:31.2092112Z scaledobject.keda.sh/redis-worker-test-hostport-triggerauth created
2021-11-01T14:59:31.2093349Z   ✖ before hook 
2021-11-01T14:59:31.2098450Z Error from server (NotFound): jobs.batch "redis-writer-host-port-ref" not found
2021-11-01T14:59:31.2100083Z Error from server (NotFound): jobs.batch "redis-writer-address-ref" not found
2021-11-01T14:59:31.2103536Z Error from server (NotFound): jobs.batch "redis-writer-host-port-trigger-auth" not found
2021-11-01T14:59:31.2105958Z scaledobject.keda.sh "redis-worker-test-hostport" deleted
2021-11-01T14:59:31.2107548Z scaledobject.keda.sh "redis-worker-test-address" deleted
2021-11-01T14:59:31.2109338Z scaledobject.keda.sh "redis-worker-test-hostport-triggerauth" deleted
2021-11-01T14:59:31.2111474Z triggerauthentication.keda.sh "keda-redis-sentinel-list-triggerauth" deleted
2021-11-01T14:59:31.2114202Z triggerauthentication.keda.sh "keda-redis-sentinel-list-triggerauth-host-port" deleted
2021-11-01T14:59:31.2116256Z deployment.apps "redis-worker-test-address" deleted
2021-11-01T14:59:31.2117958Z deployment.apps "redis-worker-test-hostport-triggerauth" deleted
2021-11-01T14:59:31.2119687Z deployment.apps "redis-worker-test-hostport" deleted
2021-11-01T14:59:31.2121018Z secret "redis-password" deleted
2021-11-01T14:59:31.2122273Z namespace "redis-sentinel-lists-test" deleted
2021-11-01T14:59:31.2123365Z release "redis-sentinel" uninstalled
2021-11-01T14:59:31.2124331Z namespace "redis-sentinel" deleted
2021-11-01T14:59:31.2125525Z   ✖ 6 tests remaining in scalers/redis-sentinel-lists.test.ts
2021-11-01T14:59:31.2126439Z   ─
2021-11-01T14:59:31.2126753Z 
2021-11-01T14:59:31.2127248Z   before hook
2021-11-01T14:59:31.2127586Z 
2021-11-01T14:59:31.2128125Z   Difference:
2021-11-01T14:59:31.2128477Z 
2021-11-01T14:59:31.2129035Z   - 0
2021-11-01T14:59:31.2129536Z   + ***
2021-11-01T14:59:31.2129836Z 
2021-11-01T14:59:31.2130778Z   › scalers/redis-sentinel-lists.test.ts:4***:6
2021-11-01T14:59:31.2131404Z 
2021-11-01T14:59:31.2131964Z   ─
2021-11-01T14:59:31.2132258Z 
2021-11-01T14:59:31.2132757Z   *** hook failed

2021-11-01T14:59:31.1350861Z >>> scalers/redis-sentinel-streams.test.ts.log <<<
2021-11-01T14:59:31.1351478Z 
2021-11-01T14:59:31.1352233Z namespace/redis-sentinel-streams created
2021-11-01T14:59:31.1353132Z "bitnami" already exists with the same configuration, skipping
2021-11-01T14:59:31.1354059Z NAME: redis-sentinel-streams
2021-11-01T14:59:31.1354747Z LAST DEPLOYED: Mon Nov  *** ***4:34:06 202***
2021-11-01T14:59:31.1355562Z NAMESPACE: redis-sentinel-streams
2021-11-01T14:59:31.1356198Z STATUS: deployed
2021-11-01T14:59:31.1356696Z REVISION: ***
2021-11-01T14:59:31.1357185Z TEST SUITE: None
2021-11-01T14:59:31.1357650Z NOTES:
2021-11-01T14:59:31.1358106Z CHART NAME: redis
2021-11-01T14:59:31.1358622Z CHART VERSION: ***5.5.3
2021-11-01T14:59:31.1359119Z APP VERSION: 6.2.6
2021-11-01T14:59:31.1359441Z 
2021-11-01T14:59:31.1360041Z ** Please be patient while the chart is being deployed **
2021-11-01T14:59:31.1360501Z 
2021-11-01T14:59:31.1361213Z Redis&trade; can be accessed via port 6379 on the following DNS name from within your cluster:
2021-11-01T14:59:31.1361783Z 
2021-11-01T14:59:31.1363370Z     redis-sentinel-streams.redis-sentinel-streams.svc.cluster.local for read only operations
2021-11-01T14:59:31.1364964Z 
2021-11-01T14:59:31.1366177Z For read/write operations, first access the Redis&trade; Sentinel cluster, which is available in port 26379 using the same domain name above.
2021-11-01T14:59:31.1367052Z 
2021-11-01T14:59:31.1367334Z 
2021-11-01T14:59:31.1367629Z 
2021-11-01T14:59:31.1368157Z To get your password run:
2021-11-01T14:59:31.1368545Z 
2021-11-01T14:59:31.1370182Z     export REDIS_PASSWORD=$(kubectl get secret --namespace redis-sentinel-streams redis-sentinel-streams -o jsonpath="{.data.redis-password}" | base64 --decode)
2021-11-01T14:59:31.1371342Z 
2021-11-01T14:59:31.1371928Z To connect to your Redis&trade; server:
2021-11-01T14:59:31.1372387Z 
2021-11-01T14:59:31.1373038Z ***. Run a Redis&trade; pod that you can use as a client:
2021-11-01T14:59:31.1373518Z 
2021-11-01T14:59:31.1375657Z    kubectl run --namespace redis-sentinel-streams redis-client --restart='Never'  --env REDIS_PASSWORD=$REDIS_PASSWORD  --image docker.io/bitnami/redis:6.2.6-debian-***0-r2*** --command -- sleep infinity
2021-11-01T14:59:31.1376955Z 
2021-11-01T14:59:31.1377513Z    Use the following command to attach to the pod:
2021-11-01T14:59:31.1377943Z 
2021-11-01T14:59:31.1378671Z    kubectl exec --tty -i redis-client \
2021-11-01T14:59:31.1379589Z    --namespace redis-sentinel-streams -- bash
2021-11-01T14:59:31.1380084Z 
2021-11-01T14:59:31.1380597Z 2. Connect using the Redis&trade; CLI:
2021-11-01T14:59:31.1381678Z    redis-cli -h redis-sentinel-streams -p 6379 -a $REDIS_PASSWORD # Read only operations
2021-11-01T14:59:31.1382966Z    redis-cli -h redis-sentinel-streams -p 26379 -a $REDIS_PASSWORD # Sentinel access
2021-11-01T14:59:31.1384170Z 
2021-11-01T14:59:31.1385041Z To connect to your database from outside the cluster execute the following commands:
2021-11-01T14:59:31.1385733Z 
2021-11-01T14:59:31.1387057Z     kubectl port-forward --namespace redis-sentinel-streams svc/redis-sentinel-streams 6379:6379 &
2021-11-01T14:59:31.1388711Z     redis-cli -h ***27.0.0.*** -p 6379 -a $REDIS_PASSWORD
2021-11-01T14:59:31.1389513Z Waiting for 3 pods to be ready...
2021-11-01T14:59:31.1390256Z Waiting for 2 pods to be ready...
2021-11-01T14:59:31.1390996Z Waiting for *** pods to be ready...
2021-11-01T14:59:31.1391783Z error: timed out waiting for the condition
2021-11-01T14:59:31.1392466Z ***0.0.***0.***53
2021-11-01T14:59:31.1393529Z namespace/redis-sentinel-streams-test created
2021-11-01T14:59:31.1394814Z secret/redis***
2021-11-01T14:59:31.1399117Z triggerauthentication.keda.sh/keda-redis-stream-triggerauth created
2021-11-01T14:59:31.1402150Z deployment.apps/redis-streams-consumer created
2021-11-01T14:59:31.1405750Z scaledobject.keda.sh/redis-streams-scaledobject created
2021-11-01T14:59:31.1408566Z   ✖ before hook expected rollout status for redis to finish successfully
2021-11-01T14:59:31.1411159Z scaledobject.keda.sh "redis-streams-scaledobject" deleted
2021-11-01T14:59:31.1414370Z triggerauthentication.keda.sh "keda-redis-stream-triggerauth" deleted
2021-11-01T14:59:31.1417351Z secret "redis-password" deleted
2021-11-01T14:59:31.1419481Z deployment.apps "redis-streams-consumer" deleted
2021-11-01T14:59:31.1422034Z Error from server (NotFound): jobs.batch "redis-streams-producer" not found
2021-11-01T14:59:31.1424575Z namespace "redis-sentinel-streams-test" deleted
2021-11-01T14:59:31.1426913Z release "redis-sentinel-streams" uninstalled
2021-11-01T14:59:31.1429096Z namespace "redis-sentinel-streams" deleted
2021-11-01T14:59:31.1431000Z   ✖ 2 tests remaining in scalers/redis-sentinel-streams.test.ts
2021-11-01T14:59:31.1432144Z   ─
2021-11-01T14:59:31.1432455Z 
2021-11-01T14:59:31.1432947Z   before hook
2021-11-01T14:59:31.1433284Z 
2021-11-01T14:59:31.1433988Z   expected rollout status for redis to finish successfully
2021-11-01T14:59:31.1434527Z 
2021-11-01T14:59:31.1435032Z   Difference:
2021-11-01T14:59:31.1435396Z 
2021-11-01T14:59:31.1435952Z   - 0
2021-11-01T14:59:31.1436458Z   + ***
2021-11-01T14:59:31.1436771Z 
2021-11-01T14:59:31.1437714Z   › scalers/redis-sentinel-streams.test.ts:30:7
2021-11-01T14:59:31.1438374Z 
2021-11-01T14:59:31.1438930Z   ─
2021-11-01T14:59:31.1439445Z 
2021-11-01T14:59:31.1439962Z   *** hook failed

Improve Redis support

af82d4b

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

jerbob92 requested review from ahmelsayed and zroubalik as code owners October 11, 2021 13:12

Update changelog

ef84416

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

jerbob92 mentioned this pull request Oct 11, 2021

Improve Redis support, add username and Sentinel kedacore/keda-docs#549

Merged

1 task

Fix scalers sorting, pass sentinelUsername in connection settings, ch…

bf437d7

…ange if statements to switch statements Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

jerbob92 mentioned this pull request Oct 12, 2021

Improve Redis support #2182

Closed

zroubalik reviewed Oct 12, 2021

View reviewed changes

zroubalik added this to the v2.5.0 milestone Oct 12, 2021

arschles suggested changes Oct 12, 2021

View reviewed changes

pkg/scalers/redis_scaler.go Outdated Show resolved Hide resolved

pkg/scalers/redis_scaler.go Show resolved Hide resolved

pkg/scalers/redis_scaler.go Show resolved Hide resolved

jerbob92 force-pushed the feature/improve-redis-support branch from bbcce79 to a6ee491 Compare October 13, 2021 07:40

jerbob92 added 2 commits October 13, 2021 09:43

Add e2e tests for sentinel

db96f64

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

Use Keda context in some cases

b5f1b40

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

jerbob92 force-pushed the feature/improve-redis-support branch from a6ee491 to b5f1b40 Compare October 13, 2021 07:43

Merge main

bac2dfe

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

jerbob92 requested a review from arschles October 13, 2021 07:46

arschles approved these changes Oct 18, 2021

View reviewed changes

jerbob92 mentioned this pull request Nov 1, 2021

Add Redis Sentinel images kedacore/test-tools#23

Merged

jerbob92 added 2 commits November 1, 2021 13:59

Merge main

98996f3

Use proper images for e2e tests

599fd09

Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>

jerbob92 force-pushed the feature/improve-redis-support branch from d2b8abe to 599fd09 Compare November 1, 2021 13:12

zroubalik approved these changes Nov 1, 2021

View reviewed changes

zroubalik merged commit 7f619bd into kedacore:main Nov 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Redis support #2181

Improve Redis support #2181

jerbob92 commented Oct 11, 2021 •

edited

Loading

tomkerkhove commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

zroubalik left a comment

jerbob92 commented Oct 12, 2021

zroubalik commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

zroubalik commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

zroubalik commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

arschles left a comment

jerbob92 commented Oct 13, 2021

zroubalik commented Oct 13, 2021

jerbob92 commented Oct 13, 2021 •

edited

Loading

zroubalik commented Oct 13, 2021

arschles left a comment

goku321 commented Oct 23, 2021

zroubalik commented Oct 23, 2021

goku321 commented Oct 23, 2021 •

edited

Loading

goku321 commented Oct 23, 2021

zroubalik commented Oct 25, 2021 •

edited

Loading

jerbob92 commented Nov 1, 2021 •

edited

Loading

zroubalik commented Nov 1, 2021

zroubalik commented Nov 1, 2021

jerbob92 commented Nov 1, 2021

zroubalik commented Nov 1, 2021

zroubalik commented Nov 1, 2021

Improve Redis support #2181

Improve Redis support #2181

Conversation

jerbob92 commented Oct 11, 2021 • edited Loading

Checklist

tomkerkhove commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

zroubalik left a comment

Choose a reason for hiding this comment

jerbob92 commented Oct 12, 2021

zroubalik commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

zroubalik commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

zroubalik commented Oct 12, 2021

jerbob92 commented Oct 12, 2021

arschles left a comment

Choose a reason for hiding this comment

jerbob92 commented Oct 13, 2021

zroubalik commented Oct 13, 2021

jerbob92 commented Oct 13, 2021 • edited Loading

zroubalik commented Oct 13, 2021

arschles left a comment

Choose a reason for hiding this comment

goku321 commented Oct 23, 2021

zroubalik commented Oct 23, 2021

goku321 commented Oct 23, 2021 • edited Loading

goku321 commented Oct 23, 2021

zroubalik commented Oct 25, 2021 • edited Loading

jerbob92 commented Nov 1, 2021 • edited Loading

zroubalik commented Nov 1, 2021

zroubalik commented Nov 1, 2021

jerbob92 commented Nov 1, 2021

zroubalik commented Nov 1, 2021

zroubalik commented Nov 1, 2021

jerbob92 commented Oct 11, 2021 •

edited

Loading

jerbob92 commented Oct 13, 2021 •

edited

Loading

goku321 commented Oct 23, 2021 •

edited

Loading

zroubalik commented Oct 25, 2021 •

edited

Loading

jerbob92 commented Nov 1, 2021 •

edited

Loading