update aws related scalers to reuse the aws clients #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a new one for every GetMetrics call Signed-off-by: Xiayang Wu <xwu@rippling.com>
Signed-off-by: Xiayang Wu <xwu@rippling.com>
|
tests also needed to be updated. to use the XXXifaces from the aws sdk, we can now mock the api calls in unit tests |
Signed-off-by: Xiayang Wu <xwu@rippling.com>
JorTurFer
approved these changes
Nov 8, 2021
zroubalik
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update aws related scalers to reuse the aws clients instead of creating a new one for every GetMetrics call
Signed-off-by: Xiayang Wu xwu@rippling.com
Provide a description of what has been changed
Refactor the aws related scalers, which includes cloudwatch, sqs and kinesis, to hold references to the dedicated aws client per scaler instance to improve performance, since the aws clients are reusable and able to refresh tokens automatically.
This is a follow up on issue: #2242
Checklist
Fixes #