Kubernetes Workload Scaler: ignore terminated pods #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Staffan Olsson <staffan@repos.se>
Signed-off-by: Staffan Olsson <staffan@repos.se>
Signed-off-by: Staffan Olsson <staffan@repos.se>
Signed-off-by: Staffan Olsson <staffan@repos.se>
JorTurFer
approved these changes
Dec 5, 2021
JorTurFer
requested changes
Dec 5, 2021
JorTurFer
requested changes
Dec 5, 2021
|
/run-e2e kubernetes-workload.test* |
Signed-off-by: Staffan Olsson <staffan@repos.se>
JorTurFer
approved these changes
Dec 6, 2021
JorTurFer
approved these changes
Dec 6, 2021
zroubalik
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubernetes-workload scaler is great, but I was surprised to discover that it counts terminated pods. While it's useful to have Shutdown or Completed pods stay around to aid for example troubleshooting I fail to come up with a use case where scaling should count them together with running. This PR excludes the two obvious terminated states from the metric value.
Checklist