Assign PostgreSQL userName to correct attribute #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Sandquist <tim.sandquist@gmail.com>
Signed-off-by: Tim Sandquist <tim.sandquist@gmail.com>
zroubalik
reviewed
Jan 3, 2022
Signed-off-by: Tim Sandquist <tim.sandquist@gmail.com>
JorTurFer
approved these changes
Jan 3, 2022
|
Nice catch! |
|
/run-e2e postgresql.test.ts |
5 tasks
alex60217101990
pushed a commit
to dysnix/keda
that referenced
this pull request
Jan 10, 2022
Signed-off-by: Tim Sandquist <tim.sandquist@gmail.com> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: alex60217101990 <alex6021710@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Sandquist tim.sandquist@gmail.com
Fix problem with PostgreSQL scaler introduced by #2114. The userName overwrites the port value when creating the connection string from individual values.
Checklist
Fixes #2430