Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Azure Pipelines to support demands #2795

Merged
merged 9 commits into from
Aug 8, 2022
Merged

Upgraded Azure Pipelines to support demands #2795

merged 9 commits into from
Aug 8, 2022

Conversation

Eldarrin
Copy link
Contributor

@Eldarrin Eldarrin commented Mar 22, 2022

Signed-off-by: mortx mortxbox@live.com

Old PR: #2707

You can now supply a master template to support demands. NOTE: You must have a master supporting agent even if it is offline!

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to kedacore/keda-docs#685
Relates to #2328

Signed-off-by: mortx <mortxbox@live.com>
@Eldarrin Eldarrin requested a review from a team as a code owner March 22, 2022 20:09
@tomkerkhove
Copy link
Member

@JorTurFer would you mind reviewing this one when you have time? It's been open for a while

@JorTurFer
Copy link
Member

I'm waiting your opinions is docs

@tomkerkhove
Copy link
Member

@Eldarrin Any thought if we can close this PR soon? We are planning to release in 2 weeks.

@Eldarrin
Copy link
Contributor Author

@tomkerkhove Its all fine and ready to be merged I believe. I'm actually running it in production at my client's organisation.

@tomkerkhove
Copy link
Member

Nice to hear! But we should probably move to the approach proposed by @JorTurFer if that's OK for you?

@Eldarrin
Copy link
Contributor Author

Ok, let me have a look. Want me to take a new fork and start from there?

@tomkerkhove
Copy link
Member

I don't have a problem if you want to update this PR, but it's up to what you prefer. We can have both approaches in parallel to compare as well if you want.

Signed-off-by: mortx <mortxbox@live.com>
Signed-off-by: mortx <mortxbox@live.com>
@Eldarrin
Copy link
Contributor Author

Now support demands and parent metadata, tested it on my clusters as working; added docs to support

@tomkerkhove
Copy link
Member

Thank you @JorTurFer Do you want to have a look?

JorTurFer
JorTurFer previously approved these changes Jul 14, 2022
@JorTurFer
Copy link
Member

JorTurFer commented Jul 14, 2022

/run-e2e pipeline
Update: You can check the progress here

@JorTurFer
Copy link
Member

I understand the "parent" approach, but requiring an already deployed deployment only for registering the job looks like overkill. Nothing to add to the code itself, but I think that we need to solve the approach for that in the docs repo.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mortx <mortxbox@live.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mortx <mortxbox@live.com>
@JorTurFer
Copy link
Member

@Eldarrin
We have plan to do a release aiming to next week, could you solve the conflicts in pkg/scalers/azure_pipelines_scaler.go to merge this PR?

@JorTurFer
Copy link
Member

There is a code linting issue, could you solve it please?

Signed-off-by: mortx <mortxbox@live.com>
@JorTurFer
Copy link
Member

JorTurFer commented Jul 29, 2022

/run-e2e pipelines*
Update: You can check the progress here

@zroubalik
Copy link
Member

@JorTurFer @v-shenoy @tomkerkhove what is the status of this?

@JorTurFer
Copy link
Member

This PR is ready but we are waiting till some things are solved in docs

@zroubalik zroubalik merged commit f216b8b into kedacore:main Aug 8, 2022
goku321 pushed a commit to goku321/keda that referenced this pull request Aug 8, 2022
Signed-off-by: mortx <mortxbox@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants