Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scaleobject ready condition 'False/Unknow' to 'True' requeue #3097

Merged
merged 6 commits into from
Jun 7, 2022
Merged

fix: scaleobject ready condition 'False/Unknow' to 'True' requeue #3097

merged 6 commits into from
Jun 7, 2022

Conversation

champly
Copy link
Contributor

@champly champly commented Jun 1, 2022 •
edited by zroubalik
Loading

Signed-off-by: champly champly@outlook.com

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3096

Relates to #

@champly
fix scaleobject ready condition 'True'->'False/Unknow' requeue
cbaebe4 
Signed-off-by: champly <champly@outlook.com>
@champly champly requested a review from a team as a code owner June 1, 2022 03:34
@champly
fix ci
03302c1 
Signed-off-by: champly <champly@outlook.com>
@tomkerkhove tomkerkhove changed the title fix scaleobject ready condition 'True'->'False/Unknow' requeue fix: scaleobject ready condition 'True'->'False/Unknow' requeue Jun 1, 2022
@champly champly changed the title fix: scaleobject ready condition 'True'->'False/Unknow' requeue fix: scaleobject ready condition 'False/Unknow' to 'True' requeue Jun 1, 2022
@zroubalik
Copy link
Member

zroubalik commented Jun 2, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

tomkerkhove
tomkerkhove reviewed Jun 2, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog please?

@champly
add change log
9098222 
Signed-off-by: champly <champly@outlook.com>
@champly
Copy link
Contributor Author

champly commented Jun 2, 2022

Can you update the changelog please?

ok, already added, PTAL.

@champly champly requested a review from tomkerkhove June 2, 2022 12:48
zroubalik
zroubalik approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik
Copy link
Member

Thanks for the contribution!

@zroubalik
Copy link
Member

zroubalik commented Jun 6, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member

@champly do you think you can write some test for this scenario?

@champly
add ut
fe3497d 
Signed-off-by: champly <champly@outlook.com>
@champly
Copy link
Contributor Author

champly commented Jun 7, 2022

@champly do you think you can write some test for this scenario?

ut have been added, and an external_mock service is hacked to simulate external service exceptions. PTAL

@champly
fix static check with sort
809be5c 
Signed-off-by: champly <champly@outlook.com>
@champly champly requested a review from zroubalik June 7, 2022 08:12
zroubalik
zroubalik reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, nice!

The only thing, why the changed perms on the Azure scaler files?

@champly
revert file permission
b176e8b 
Signed-off-by: champly <champly@outlook.com>
@champly
Copy link
Contributor Author

champly commented Jun 7, 2022

Oh, it should be edited automatically by the editor, it has been revert.

zroubalik
zroubalik approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik
Copy link
Member

zroubalik commented Jun 7, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik zroubalik merged commit e816248 into kedacore:main Jun 7, 2022
@champly champly deleted the fix-so-condition-requeue branch June 7, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

Assignees
No one assigned
Labels
ok-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScaledObject ready condition changed will not fix HPA in some situation
3 participants
@champly @zroubalik @tomkerkhove