Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add info about aad-pod-identity deprecation #5036

Merged
merged 4 commits into from
Oct 15, 2023
Merged

chore: add info about aad-pod-identity deprecation #5036

merged 4 commits into from
Oct 15, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 1, 2023 •
edited
Loading

Checklist

Relates to #5035

@JorTurFer
chore: add info about aad-pod-identity deprecagtion
7c96df8 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner October 1, 2023 20:18
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer JorTurFer mentioned this pull request Oct 1, 2023
Closed
@JorTurFer
Copy link
Member Author

@tomkerkhove ?

tomkerkhove
tomkerkhove approved these changes Oct 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tomkerkhove tomkerkhove changed the title chore: add info about aad-pod-identity deprecagtion chore: add info about aad-pod-identity deprecation Oct 4, 2023
@JorTurFer @tomkerkhove
Update CHANGELOG.md
a81e546 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer enabled auto-merge (squash) October 4, 2023 09:26
tomkerkhove
tomkerkhove reviewed Oct 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer @tomkerkhove
Update pkg/scaling/resolver/scale_resolvers.go
1694fc8 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

/skip-e2e

@JorTurFer @tomkerkhove
Update CHANGELOG.md
5f1d82e 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer merged commit b314194 into kedacore:main Oct 15, 2023
19 checks passed
@JorTurFer JorTurFer deleted the deprecate-aad branch October 15, 2023 19:55
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@JorTurFer @tomkerkhove @toniiiik
chore: add info about aad-pod-identity deprecation (kedacore#5036)
116be52 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorTurFer @zroubalik @tomkerkhove @keda-automation