Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support TriggerAuthentication properties from ConfigMap #5111

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: support TriggerAuthentication properties from ConfigMap #5111

merged 1 commit into from
Oct 27, 2023

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Oct 21, 2023 •
edited
Loading

This PR proposes an implementation to support for TriggerAuthentication properties from ConfigMap.

Checklist

Fixes #4830

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@wozniakjan
feat: support TriggerAuthentication properties from ConfigMap
3e646b1 
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan marked this pull request as ready for review October 21, 2023 13:03
@wozniakjan wozniakjan requested a review from a team as a code owner October 21, 2023 13:03
@wozniakjan wozniakjan mentioned this pull request Oct 25, 2023
Merged
1 task
@wozniakjan
Copy link
Member Author

wozniakjan commented Oct 25, 2023 •
edited
Loading

ptal
/cc @zroubalik @JorTurFer @novicr

zroubalik
zroubalik approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik
Copy link
Member

zroubalik commented Oct 26, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@wozniakjan
Copy link
Member Author

/run-e2e internal
the failure of e2e tests seems unrelated to the changes, perhaps flake?

Failed tests:
7765
	Execution of tests/internals/scaling_modifiers/scaling_modifiers_test.go, has failed after "three" attempts

@zroubalik
Copy link
Member

/run-e2e internal the failure of e2e tests seems unrelated to the changes, perhaps flake?

Failed tests:
7765
	Execution of tests/internals/scaling_modifiers/scaling_modifiers_test.go, has failed after "three" attempts

yes :(

@zroubalik zroubalik merged commit 3435623 into kedacore:main Oct 27, 2023
18 of 19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@wozniakjan @toniiiik
feat: support TriggerAuthentication properties from ConfigMap (kedaco…
d105eb1 
…re#5111)

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
@JorTurFer JorTurFer mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow properties from ConfigMap in TriggerAuthentication
2 participants
@wozniakjan @zroubalik