Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Adding ScaledObject.Status Conditions #750

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Adding Conditions to the ScaledObject(and potentially ScaledJob) Status. It's kubernetes standard way how to inform users. Adding 2 conditions:

  • Ready this is set to True if ScaledObject is correctly specified and able to get metrics
  • Active informs user whether scaling is active, not active or whether cooldown is happennig

Here you can see snippets of ScaledObject output:

$ oc get scaledobject test-scaledobject
NAME                 SCALETARGETKIND      SCALETARGETNAME   TRIGGERS      READY   ACTIVE    AGE
test-scaledobject   apps/v1.Deployment   test-keda        azure-queue      True    False   22s
$ oc get scaledobject test-scaledobject -oyaml
...
status:
  conditions:
  - message: ScaledObject is defined correctly and is ready for scaling
    reason: ScaledObjectReady
    status: "True"
    type: Ready
  - message: Scaler cooling down because triggers are not active
    reason: ScalerCooldown
    status: "False"
    type: Active
...

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #51

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@ahmelsayed ahmelsayed merged commit 32120ef into kedacore:v2 Apr 16, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Apr 27, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request May 20, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Jun 17, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Jul 7, 2020
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Relates to kedacore#2773

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants