Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] removed deprecated brokerList #882

Merged
merged 3 commits into from
Jun 17, 2020
Merged

[v2] removed deprecated brokerList #882

merged 3 commits into from
Jun 17, 2020

Conversation

samuelmacko
Copy link
Contributor

Fixes: #632

Signed-off-by: Samuel Macko samuel.macko.sm@gmail.com

Provide a description of what has been changed

Checklist

Fixes #

Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog fix needed

CHANGELOG.md Outdated
@@ -81,7 +79,7 @@ None.
### Improvements

- Make targetQueryValue configurable in postgreSQL scaler ([#643](https://github.com/kedacore/keda/pull/643))
- Added bootstrapServers to deprecate brokerList ([#621](https://github.com/kedacore/keda/pull/621))
- Removed deprecated brokerList ([#621](https://github.com/kedacore/keda/pull/621))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in section ## v2.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it should point to this PR

@zroubalik zroubalik changed the title removed deprecated brokerList [v2] removed deprecated brokerList Jun 16, 2020
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 3455485 into kedacore:v2 Jun 17, 2020
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Jun 17, 2020
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Jul 7, 2020
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
zroubalik pushed a commit that referenced this pull request Aug 6, 2020
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants