Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make kedro-datasets open-bound #308

Closed
wants to merge 1 commit into from

Conversation

SajidAlamQB
Copy link
Contributor

Description

Add open-bound to kedro-datasets to unblock work on adding python 3.11 support to kedro-datasets, #297.

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add some sort of warning like we did on kedro-org/kedro#2742 ? Otherwise this is fine by me

@noklam
Copy link
Contributor

noklam commented Aug 17, 2023

Why do we need a separate PR to remove the bound? Can we do it in the same PR.

@SajidAlamQB
Copy link
Contributor Author

SajidAlamQB commented Aug 17, 2023

Why do we need a separate PR to remove the bound? Can we do it in the same PR.

It initially looked like the dependencies were failing because of the open-bound not being committed to main this has since been fixed in the PR so will close this.

@SajidAlamQB SajidAlamQB deleted the bump/lift-upper-bound-on-datasets branch August 17, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants